changeset 53624:11b97acc9c7f

8213997: Remove G1HRRSUseSparseTable flag Summary: Remove develop flag because it is not used anyway. Reviewed-by: shade, manc
author tschatzl
date Thu, 22 Nov 2018 09:25:19 +0100
parents c88468bc7690
children 533b02f7842c
files src/hotspot/share/gc/g1/g1_globals.hpp src/hotspot/share/gc/g1/heapRegionRemSet.cpp
diffstat 2 files changed, 10 insertions(+), 16 deletions(-) [+]
line wrap: on
line diff
--- a/src/hotspot/share/gc/g1/g1_globals.hpp	Thu Nov 22 09:23:05 2018 +0100
+++ b/src/hotspot/share/gc/g1/g1_globals.hpp	Thu Nov 22 09:25:19 2018 +0100
@@ -190,9 +190,6 @@
           "to minimize the probability of promotion failure.")              \
           range(0, 50)                                                      \
                                                                             \
-  develop(bool, G1HRRSUseSparseTable, true,                                 \
-          "When true, use sparse table to save space.")                     \
-                                                                            \
   product(size_t, G1HeapRegionSize, 0,                                      \
           "Size of the G1 regions.")                                        \
           range(0, 32*M)                                                    \
--- a/src/hotspot/share/gc/g1/heapRegionRemSet.cpp	Thu Nov 22 09:23:05 2018 +0100
+++ b/src/hotspot/share/gc/g1/heapRegionRemSet.cpp	Thu Nov 22 09:25:19 2018 +0100
@@ -368,8 +368,7 @@
 
       CardIdx_t card_index = card_within_region(from, from_hr);
 
-      if (G1HRRSUseSparseTable &&
-          _sparse_table.add_card(from_hrm_ind, card_index)) {
+      if (_sparse_table.add_card(from_hrm_ind, card_index)) {
         assert(contains_reference_locked(from), "We just added " PTR_FORMAT " to the Sparse table", p2i(from));
         return;
       }
@@ -397,18 +396,16 @@
       OrderAccess::release_store(&_fine_grain_regions[ind], prt);
       _n_fine_entries++;
 
-      if (G1HRRSUseSparseTable) {
-        // Transfer from sparse to fine-grain.
-        SparsePRTEntry *sprt_entry = _sparse_table.get_entry(from_hrm_ind);
-        assert(sprt_entry != NULL, "There should have been an entry");
-        for (int i = 0; i < sprt_entry->num_valid_cards(); i++) {
-          CardIdx_t c = sprt_entry->card(i);
-          prt->add_card(c);
-        }
-        // Now we can delete the sparse entry.
-        bool res = _sparse_table.delete_entry(from_hrm_ind);
-        assert(res, "It should have been there.");
+      // Transfer from sparse to fine-grain.
+      SparsePRTEntry *sprt_entry = _sparse_table.get_entry(from_hrm_ind);
+      assert(sprt_entry != NULL, "There should have been an entry");
+      for (int i = 0; i < sprt_entry->num_valid_cards(); i++) {
+        CardIdx_t c = sprt_entry->card(i);
+        prt->add_card(c);
       }
+      // Now we can delete the sparse entry.
+      bool res = _sparse_table.delete_entry(from_hrm_ind);
+      assert(res, "It should have been there.");
     }
     assert(prt != NULL && prt->hr() == from_hr, "consequence");
   }