changeset 50597:20520a835f48

8202597: javac is not inducing a notional interface if Object appears in an intersection type Reviewed-by: mcimadamore
author vromero
date Tue, 08 May 2018 17:12:54 -0700
parents 06d5b1f66553
children e64e3cd120b7
files src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java test/langtools/tools/javac/T8202597/NotionalInterfaceNotBeingInducedTest.java test/langtools/tools/javac/diags/examples/NotAnInterfaceComponent.java test/langtools/tools/javac/lambda/intersection/IntersectionTargetTypeTest.java
diffstat 4 files changed, 48 insertions(+), 4 deletions(-) [+]
line wrap: on
line diff
--- a/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java	Tue May 08 23:02:13 2018 +0200
+++ b/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java	Tue May 08 17:12:54 2018 -0700
@@ -2705,6 +2705,9 @@
                 Type target = null;
                 for (Type bound : ict.getExplicitComponents()) {
                     TypeSymbol boundSym = bound.tsym;
+                    if (bound.tsym == syms.objectType.tsym) {
+                        continue;
+                    }
                     if (types.isFunctionalInterface(boundSym) &&
                             types.findDescriptorSymbol(boundSym) == desc) {
                         target = bound;
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/test/langtools/tools/javac/T8202597/NotionalInterfaceNotBeingInducedTest.java	Tue May 08 17:12:54 2018 -0700
@@ -0,0 +1,41 @@
+/*
+ * Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/*
+ * @test
+ * @bug 8202597
+ * @summary javac is not inducing a notional interface if Object appears in an intersection type
+ * @compile NotionalInterfaceNotBeingInducedTest.java
+ */
+
+class NotionalInterfaceNotBeingInducedTest {
+    interface I {}
+    interface J { void foo(); }
+
+    public void test() {
+        Object o1 = (I & J) System::gc;
+        Object o2 = (J) System::gc;
+        Object o3 = (Object & J) System::gc;
+        Object o4 = (Object & I & J) System::gc;
+    }
+}
--- a/test/langtools/tools/javac/diags/examples/NotAnInterfaceComponent.java	Tue May 08 23:02:13 2018 +0200
+++ b/test/langtools/tools/javac/diags/examples/NotAnInterfaceComponent.java	Tue May 08 17:12:54 2018 -0700
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2013, 2018, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -26,5 +26,5 @@
 // key: compiler.misc.not.an.intf.component
 
 class NotAnInterfaceComponent {
-    Object o = (Object & Runnable) ()-> { };
+    Object o = (String & Runnable) ()-> { };
 }
--- a/test/langtools/tools/javac/lambda/intersection/IntersectionTargetTypeTest.java	Tue May 08 23:02:13 2018 +0200
+++ b/test/langtools/tools/javac/lambda/intersection/IntersectionTargetTypeTest.java	Tue May 08 17:12:54 2018 -0700
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2012, 2017, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2012, 2018, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -276,7 +276,7 @@
         if (ek.isFunctional) {
             List<MethodKind> mks = new ArrayList<>();
             for (TypeKind tk : cInfo.types) {
-                if (tk.boundKind == BoundKind.CLASS) {
+                if (tk.boundKind == BoundKind.CLASS && !tk.typeStr.equals("Object")) {
                     errorExpected = true;
                     break;
                 } else {