changeset 23538:2518569e1e01

8038628: Remove unused Closure::abort() Reviewed-by: coleenp, jmasa
author stefank
date Fri, 28 Mar 2014 14:03:11 +0100
parents 3de0cad00ae1
children 6382fd0ea303
files hotspot/src/share/vm/gc_implementation/g1/heapRegion.cpp hotspot/src/share/vm/memory/iterator.hpp
diffstat 2 files changed, 2 insertions(+), 18 deletions(-) [+]
line wrap: on
line diff
--- a/hotspot/src/share/vm/gc_implementation/g1/heapRegion.cpp	Wed Mar 12 15:25:35 2014 +0100
+++ b/hotspot/src/share/vm/gc_implementation/g1/heapRegion.cpp	Fri Mar 28 14:03:11 2014 +0100
@@ -472,9 +472,6 @@
     } else if (!g1h->is_obj_dead(obj)) {
       cl->do_object(obj);
     }
-    if (cl->abort()) return cur;
-    // The check above must occur before the operation below, since an
-    // abort might invalidate the "size" operation.
     cur += obj->size();
   }
   return NULL;
--- a/hotspot/src/share/vm/memory/iterator.hpp	Wed Mar 12 15:25:35 2014 +0100
+++ b/hotspot/src/share/vm/memory/iterator.hpp	Fri Mar 28 14:03:11 2014 +0100
@@ -30,8 +30,6 @@
 #include "runtime/prefetch.hpp"
 #include "utilities/top.hpp"
 
-// The following classes are C++ `closures` for iterating over objects, roots and spaces
-
 class CodeBlob;
 class nmethod;
 class ReferenceProcessor;
@@ -39,22 +37,11 @@
 class KlassClosure;
 class ClassLoaderData;
 
-// Closure provides abortability.
+// The following classes are C++ `closures` for iterating over objects, roots and spaces
 
-class Closure : public StackObj {
- protected:
-  bool _abort;
-  void set_abort() { _abort = true; }
- public:
-  Closure() : _abort(false) {}
-  // A subtype can use this mechanism to indicate to some iterator mapping
-  // functions that the iteration should cease.
-  bool abort() { return _abort; }
-  void clear_abort() { _abort = false; }
-};
+class Closure : public StackObj { };
 
 // OopClosure is used for iterating through references to Java objects.
-
 class OopClosure : public Closure {
  public:
   virtual void do_oop(oop* o) = 0;