changeset 56603:27d3b8e5c58b

8224240: Properties.load fails to throw IAE on malformed unicode in certain circumstances Reviewed-by: smarks, rriggs, dfuchs
author redestad
date Wed, 05 Jun 2019 10:23:06 +0200
parents 28c93b5fb056
children a5967fd63d9d
files src/java.base/share/classes/java/util/Properties.java test/jdk/java/util/Properties/PropertiesTest.java
diffstat 2 files changed, 25 insertions(+), 6 deletions(-) [+]
line wrap: on
line diff
--- a/src/java.base/share/classes/java/util/Properties.java	Wed Jun 05 10:07:22 2019 +0200
+++ b/src/java.base/share/classes/java/util/Properties.java	Wed Jun 05 10:23:06 2019 +0200
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1995, 2018, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1995, 2019, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -641,11 +641,16 @@
         while (off < end) {
             aChar = in[off++];
             if (aChar == '\\') {
+                // No need to bounds check since LineReader::readLine excludes
+                // unescaped \s at the end of the line
                 aChar = in[off++];
                 if(aChar == 'u') {
                     // Read the xxxx
-                    int value=0;
-                    for (int i=0; i<4; i++) {
+                    if (off > end - 4)
+                        throw new IllegalArgumentException(
+                                     "Malformed \\uxxxx encoding.");
+                    int value = 0;
+                    for (int i = 0; i < 4; i++) {
                         aChar = in[off++];
                         switch (aChar) {
                           case '0': case '1': case '2': case '3': case '4':
--- a/test/jdk/java/util/Properties/PropertiesTest.java	Wed Jun 05 10:07:22 2019 +0200
+++ b/test/jdk/java/util/Properties/PropertiesTest.java	Wed Jun 05 10:23:06 2019 +0200
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -25,7 +25,7 @@
  * @test
  * @summary tests the load and store methods of Properties class
  * @author Xueming Shen
- * @bug 4094886
+ * @bug 4094886 8224202
  * @modules jdk.charsets
  * @key randomness
  */
@@ -411,9 +411,23 @@
     }
 
     private static void UnicodeEscape() throws Exception {
+        checkMalformedUnicodeEscape("b=\\u012\n");
+        checkMalformedUnicodeEscape("b=\\u01\n");
+        checkMalformedUnicodeEscape("b=\\u0\n");
+        checkMalformedUnicodeEscape("b=\\u\n");
+        checkMalformedUnicodeEscape("a=\\u0123\nb=\\u012\n");
+        checkMalformedUnicodeEscape("a=\\u0123\nb=\\u01\n");
+        checkMalformedUnicodeEscape("a=\\u0123\nb=\\u0\n");
+        checkMalformedUnicodeEscape("a=\\u0123\nb=\\u\n");
+        checkMalformedUnicodeEscape("b=\\u012xyz\n");
+        checkMalformedUnicodeEscape("b=x\\u012yz\n");
+        checkMalformedUnicodeEscape("b=xyz\\u012\n");
+    }
+
+    private static void checkMalformedUnicodeEscape(String propString) throws Exception {
         ByteArrayOutputStream baos = new ByteArrayOutputStream();
         OutputStreamWriter osw = new OutputStreamWriter(baos);
-        osw.write("a=b\nb=\\u0\n");
+        osw.write(propString);
         osw.close();
         Properties props = new Properties();
         boolean failed = true;