changeset 16276:4437442f3523

8009553: Object.create(Array.prototype) doesn't respect reset length Reviewed-by: jlaskey, lagergren
author sundar
date Wed, 06 Mar 2013 22:38:18 +0530
parents d5d430071b22
children fd698c5ee684
files nashorn/src/jdk/nashorn/internal/objects/Global.java nashorn/test/script/basic/JDK-8009553.js
diffstat 2 files changed, 57 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/nashorn/src/jdk/nashorn/internal/objects/Global.java	Mon Mar 04 11:01:26 2013 -0400
+++ b/nashorn/src/jdk/nashorn/internal/objects/Global.java	Wed Mar 06 22:38:18 2013 +0530
@@ -1385,7 +1385,7 @@
 
         // add Array.prototype.length
         final ScriptObject arrayPrototype = getArrayPrototype();
-        arrayPrototype.addOwnProperty("length", Attribute.NON_ENUMERABLE_CONSTANT, 0.0);
+        arrayPrototype.addOwnProperty("length", Attribute.NOT_ENUMERABLE|Attribute.NOT_CONFIGURABLE, 0.0);
 
         this.DEFAULT_DATE = new NativeDate(Double.NaN);
 
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/nashorn/test/script/basic/JDK-8009553.js	Wed Mar 06 22:38:18 2013 +0530
@@ -0,0 +1,56 @@
+/*
+ * Copyright (c) 2010, 2013, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ * 
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ * 
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ * 
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ * 
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/**
+ * JDK-8009553: Object.create(Array.prototype) doesn't respect reset length
+ *
+ * @test
+ * @run
+ */
+
+var desc = Object.getOwnPropertyDescriptor(Array.prototype, "length");
+if (! desc.writable) {
+    fail("Array.prototype.length is not writable");
+}
+
+if (desc.value != 0) {
+    fail("Array.prototype.length != 0");
+}
+
+var array = Object.create(Array.prototype);
+if (array.hasOwnProperty("length")) {
+    fail("array has 'length'");
+}
+
+if (array.length != 0) {
+    fail("array.length != 0");
+}
+
+array.length = 4;
+if (! array.hasOwnProperty("length")) {
+    fail("array does not have 'length'");
+}
+
+if (array.length != 4) {
+    fail("array.length != 4");
+}