OpenJDK / amber / amber
changeset 34334:512c85086978
8143913: MSCAPI keystore should accept Certificate[] in setEntry()
Reviewed-by: vinnie
author | weijun |
---|---|
date | Wed, 25 Nov 2015 11:58:30 +0800 |
parents | 649abc6c35eb |
children | ef0ba9ee7cde |
files | jdk/src/jdk.crypto.mscapi/windows/classes/sun/security/mscapi/KeyStore.java jdk/test/sun/security/mscapi/CastError.java |
diffstat | 2 files changed, 66 insertions(+), 2 deletions(-) [+] |
line wrap: on
line diff
--- a/jdk/src/jdk.crypto.mscapi/windows/classes/sun/security/mscapi/KeyStore.java Wed Nov 25 09:42:34 2015 +0800 +++ b/jdk/src/jdk.crypto.mscapi/windows/classes/sun/security/mscapi/KeyStore.java Wed Nov 25 11:58:30 2015 +0800 @@ -389,10 +389,22 @@ } } + X509Certificate[] xchain; + if (chain != null) { + if (chain instanceof X509Certificate[]) { + xchain = (X509Certificate[]) chain; + } else { + xchain = new X509Certificate[chain.length]; + System.arraycopy(chain, 0, xchain, 0, chain.length); + } + } else { + xchain = null; + } + if (! found) { entry = //TODO new KeyEntry(alias, key, (X509Certificate[]) chain); - new KeyEntry(alias, null, (X509Certificate[]) chain); + new KeyEntry(alias, null, xchain); entries.add(entry); } @@ -400,7 +412,7 @@ try { entry.setPrivateKey((RSAPrivateCrtKey) key); - entry.setCertificateChain((X509Certificate[]) chain); + entry.setCertificateChain(xchain); } catch (CertificateException ce) { throw new KeyStoreException(ce);
--- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/jdk/test/sun/security/mscapi/CastError.java Wed Nov 25 11:58:30 2015 +0800 @@ -0,0 +1,52 @@ +/* + * Copyright (c) 2015 Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +import java.io.File; +import java.security.KeyStore; +import java.security.PrivateKey; +import java.security.cert.Certificate; + +/** + * @test + * @bug 8143913 + * @requires os.family == "windows" + * @summary MSCAPI keystore should accept Certificate[] in setEntry() + */ + +public class CastError { + public static void main(String[] args) throws Exception { + KeyStore ks = KeyStore.getInstance( + new File(System.getProperty("test.src"), + "../tools/jarsigner/JarSigning.keystore"), + "bbbbbb".toCharArray()); + + PrivateKey pk = (PrivateKey) ks.getKey("c", "bbbbbb".toCharArray()); + Certificate cert = ks.getCertificate("c"); + + ks = KeyStore.getInstance("Windows-MY"); + ks.load(null, null); + + ks.setKeyEntry("8143913", pk, null, new Certificate[]{cert}); + ks.deleteEntry("8143913"); + } +}