changeset 46049:582273afc391

8185589: jdk.management API has accessibility issues Reviewed-by: alanb
author jjg
date Mon, 31 Jul 2017 17:37:46 -0700
parents 00b5dc9d9be5
children f51c14dc540f
files jdk/src/jdk.management/share/classes/com/sun/management/DiagnosticCommandMBean.java jdk/src/jdk.management/share/classes/com/sun/management/GarbageCollectionNotificationInfo.java jdk/src/jdk.management/share/classes/com/sun/management/GcInfo.java jdk/src/jdk.management/share/classes/com/sun/management/VMOption.java
diffstat 4 files changed, 56 insertions(+), 36 deletions(-) [+]
line wrap: on
line diff
--- a/jdk/src/jdk.management/share/classes/com/sun/management/DiagnosticCommandMBean.java	Mon Jul 31 16:02:23 2017 -0700
+++ b/jdk/src/jdk.management/share/classes/com/sun/management/DiagnosticCommandMBean.java	Mon Jul 31 17:37:46 2017 -0700
@@ -107,35 +107,38 @@
  * diagnostic command are described in the table below:
  *
  * <table class="striped"><caption style="display:none">description</caption>
+ *   <thead>
  *   <tr>
- *     <th>Name</th><th>Type</th><th>Description</th>
+ *     <th scope="col">Name</th><th scope="col">Type</th><th scope="col">Description</th>
  *   </tr>
+ *   </thead>
+ *   <tbody>
  *   <tr>
- *     <td>dcmd.name</td><td>String</td>
+ *     <th scope="row">dcmd.name</th><td>String</td>
  *     <td>The original diagnostic command name (not the operation name)</td>
  *   </tr>
  *   <tr>
- *     <td>dcmd.description</td><td>String</td>
+ *     <th scope="row">dcmd.description</th><td>String</td>
  *     <td>The diagnostic command description</td>
  *   </tr>
  *   <tr>
- *     <td>dcmd.help</td><td>String</td>
+ *     <th scope="row">dcmd.help</th><td>String</td>
  *     <td>The full help message for this diagnostic command (same output as
  *          the one produced by the 'help' command)</td>
  *   </tr>
  *   <tr>
- *     <td>dcmd.vmImpact</td><td>String</td>
+ *     <th scope="row">dcmd.vmImpact</th><td>String</td>
  *     <td>The impact of the diagnostic command,
  *      this value is the same as the one printed in the 'impact'
  *      section of the help message of the diagnostic command, and it
  *      is different from the getImpact() of the MBeanOperationInfo</td>
  *   </tr>
  *   <tr>
- *     <td>dcmd.enabled</td><td>boolean</td>
+ *     <th scope="row">dcmd.enabled</th><td>boolean</td>
  *     <td>True if the diagnostic command is enabled, false otherwise</td>
  *   </tr>
  *   <tr>
- *     <td>dcmd.permissionClass</td><td>String</td>
+ *     <th scope="row">dcmd.permissionClass</th><td>String</td>
  *     <td>Some diagnostic command might require a specific permission to be
  *          executed, in addition to the MBeanPermission to invoke their
  *          associated MBean operation. This field returns the fully qualified
@@ -143,22 +146,23 @@
  *   </td>
  *   </tr>
  *   <tr>
- *     <td>dcmd.permissionName</td><td>String</td>
+ *     <th scope="row">dcmd.permissionName</th><td>String</td>
  *     <td>The fist argument of the permission required to execute this
  *          diagnostic command or null if no permission is required</td>
  *   </tr>
  *   <tr>
- *     <td>dcmd.permissionAction</td><td>String</td>
+ *     <th scope="row">dcmd.permissionAction</th><td>String</td>
  *     <td>The second argument of the permission required to execute this
  *          diagnostic command or null if the permission constructor has only
  *          one argument (like the ManagementPermission) or if no permission
  *          is required</td>
  *   </tr>
  *   <tr>
- *     <td>dcmd.arguments</td><td>Descriptor</td>
+ *     <th scope="row">dcmd.arguments</th><td>Descriptor</td>
  *     <td>A Descriptor instance containing the descriptions of options and
  *          arguments supported by the diagnostic command (see below)</td>
  *   </tr>
+ *   </tbody>
  * </table>
  *
  * <p>The description of parameters (options or arguments) of a diagnostic
@@ -168,37 +172,41 @@
  * instance are described in the table below:
  *
  * <table class="striped"><caption style="display:none">description</caption>
+ *   <thead>
  *   <tr>
- *     <th>Name</th><th>Type</th><th>Description</th>
+ *     <th scope="col">Name</th><th scope="col">Type</th><th scope="col">Description</th>
  *   </tr>
+ *   </thead>
+ *   <tbody>
  *   <tr>
- *     <td>dcmd.arg.name</td><td>String</td>
+ *     <th scope="row">dcmd.arg.name</th><td>String</td>
  *     <td>The name of the parameter</td>
  *   </tr>
  *   <tr>
- *     <td>dcmd.arg.type</td><td>String</td>
+ *     <th scope="row">dcmd.arg.type</th><td>String</td>
  *     <td>The type of the parameter. The returned String is the name of a type
  *          recognized by the diagnostic command parser. These types are not
  *          Java types and are implementation dependent.
  *          </td>
  *   </tr>
  *   <tr>
- *     <td>dcmd.arg.description</td><td>String</td>
+ *     <th scope="row">dcmd.arg.description</th><td>String</td>
  *     <td>The parameter description</td>
  *   </tr>
  *   <tr>
- *     <td>dcmd.arg.isMandatory</td><td>boolean</td>
+ *     <th scope="row">dcmd.arg.isMandatory</th><td>boolean</td>
  *     <td>True if the parameter is mandatory, false otherwise</td>
  *   </tr>
  *   <tr>
- *     <td>dcmd.arg.isOption</td><td>boolean</td>
+ *     <th scope="row">dcmd.arg.isOption</th><td>boolean</td>
  *     <td>True if the parameter is an option, false if it is an argument</td>
  *   </tr>
  *   <tr>
- *     <td>dcmd.arg.isMultiple</td><td>boolean</td>
+ *     <th scope="row">dcmd.arg.isMultiple</th><td>boolean</td>
  *     <td>True if the parameter can be specified several times, false
  *          otherwise</td>
  *   </tr>
+ *   </tbody>
  * </table>
  *
  * <p>When the set of diagnostic commands currently supported by the Java
--- a/jdk/src/jdk.management/share/classes/com/sun/management/GarbageCollectionNotificationInfo.java	Mon Jul 31 16:02:23 2017 -0700
+++ b/jdk/src/jdk.management/share/classes/com/sun/management/GarbageCollectionNotificationInfo.java	Mon Jul 31 17:37:46 2017 -0700
@@ -182,26 +182,30 @@
      * the following attributes:
      * <blockquote>
      * <table class="striped"><caption style="display:none">description</caption>
+     * <thead>
      * <tr>
-     *   <th style="text-align:left">Attribute Name</th>
-     *   <th style="text-align:left">Type</th>
+     *   <th scope="col" style="text-align:left">Attribute Name</th>
+     *   <th scope="col" style="text-align:left">Type</th>
      * </tr>
+     * </thead>
+     * <tbody>
      * <tr>
-     *   <td>gcName</td>
+     *   <th scope="row">gcName</th>
      *   <td>{@code java.lang.String}</td>
      * </tr>
      * <tr>
-     *   <td>gcAction</td>
+     *   <th scope="row">gcAction</th>
      *   <td>{@code java.lang.String}</td>
      * </tr>
      * <tr>
-     *   <td>gcCause</td>
+     *   <th scope="row">gcCause</th>
      *   <td>{@code java.lang.String}</td>
      * </tr>
      * <tr>
-     *   <td>gcInfo</td>
+     *   <th scope="row">gcInfo</th>
      *   <td>{@code javax.management.openmbean.CompositeData}</td>
      * </tr>
+     * </tbody>
      * </table>
      * </blockquote>
      *
--- a/jdk/src/jdk.management/share/classes/com/sun/management/GcInfo.java	Mon Jul 31 16:02:23 2017 -0700
+++ b/jdk/src/jdk.management/share/classes/com/sun/management/GcInfo.java	Mon Jul 31 17:37:46 2017 -0700
@@ -184,30 +184,34 @@
      *
      * <blockquote>
      * <table class="striped"><caption style="display:none">description</caption>
+     * <thead>
      * <tr>
-     *   <th style="text-align:left">Attribute Name</th>
-     *   <th style="text-align:left">Type</th>
+     *   <th scope="col" style="text-align:left">Attribute Name</th>
+     *   <th scope="col" style="text-align:left">Type</th>
      * </tr>
+     * </thead>
+     * <tbody>
      * <tr>
-     *   <td>index</td>
+     *   <th scope="row">index</th>
      *   <td>{@code java.lang.Long}</td>
      * </tr>
      * <tr>
-     *   <td>startTime</td>
+     *   <th scope="row">startTime</th>
      *   <td>{@code java.lang.Long}</td>
      * </tr>
      * <tr>
-     *   <td>endTime</td>
+     *   <th scope="row">endTime</th>
      *   <td>{@code java.lang.Long}</td>
      * </tr>
      * <tr>
-     *   <td>memoryUsageBeforeGc</td>
+     *   <th scope="row">memoryUsageBeforeGc</th>
      *   <td>{@code javax.management.openmbean.TabularData}</td>
      * </tr>
      * <tr>
-     *   <td>memoryUsageAfterGc</td>
+     *   <th scope="row">memoryUsageAfterGc</th>
      *   <td>{@code javax.management.openmbean.TabularData}</td>
      * </tr>
+     * </tbody>
      * </table>
      * </blockquote>
      *
--- a/jdk/src/jdk.management/share/classes/com/sun/management/VMOption.java	Mon Jul 31 16:02:23 2017 -0700
+++ b/jdk/src/jdk.management/share/classes/com/sun/management/VMOption.java	Mon Jul 31 17:37:46 2017 -0700
@@ -191,26 +191,30 @@
      *
      * <blockquote>
      * <table class="striped"><caption style="display:none">description</caption>
+     * <thead>
      * <tr>
-     *   <th style="text-align:left">Attribute Name</th>
-     *   <th style="text-align:left">Type</th>
+     *   <th scope="col" style="text-align:left">Attribute Name</th>
+     *   <th scope="col" style="text-align:left">Type</th>
      * </tr>
+     * </thead>
+     * <tbody>
      * <tr>
-     *   <td>name</td>
+     *   <th scope="row">name</th>
      *   <td>{@code java.lang.String}</td>
      * </tr>
      * <tr>
-     *   <td>value</td>
+     *   <th scope="row">value</th>
      *   <td>{@code java.lang.String}</td>
      * </tr>
      * <tr>
-     *   <td>origin</td>
+     *   <th scope="row">origin</th>
      *   <td>{@code java.lang.String}</td>
      * </tr>
      * <tr>
-     *   <td>writeable</td>
+     *   <th scope="row">writeable</th>
      *   <td>{@code java.lang.Boolean}</td>
      * </tr>
+     * </tbody>
      * </table>
      * </blockquote>
      *