changeset 30141:604c96a33147

8068007: [Findbugs] SA com.sun.java.swing.action.ActionManager.manager should be package protect Summary: fixed java programming style nit Reviewed-by: dholmes, jbachorik, sspitsyn
author dsamersoff
date Thu, 02 Apr 2015 13:20:49 -0700
parents 35599707b3f7
children 0ee0d7d0ee80
files hotspot/agent/src/share/classes/com/sun/java/swing/action/ActionManager.java hotspot/agent/src/share/classes/sun/jvm/hotspot/ui/action/HSDBActionManager.java
diffstat 2 files changed, 11 insertions(+), 4 deletions(-) [+]
line wrap: on
line diff
--- a/hotspot/agent/src/share/classes/com/sun/java/swing/action/ActionManager.java	Thu Apr 02 17:22:22 2015 +0000
+++ b/hotspot/agent/src/share/classes/com/sun/java/swing/action/ActionManager.java	Thu Apr 02 13:20:49 2015 -0700
@@ -46,6 +46,11 @@
         return manager;
     }
 
+    protected static void setInstance(ActionManager m)
+    {
+        manager = m;
+    }
+
     protected abstract void addActions();
 
     protected void addAction(String cmdname, Action action)
@@ -90,6 +95,6 @@
 
     private HashMap actions;
     private static ActionUtilities utilities = new ActionUtilities();
-    protected static ActionManager manager;
+    private static ActionManager manager;
 
 }
--- a/hotspot/agent/src/share/classes/sun/jvm/hotspot/ui/action/HSDBActionManager.java	Thu Apr 02 17:22:22 2015 +0000
+++ b/hotspot/agent/src/share/classes/sun/jvm/hotspot/ui/action/HSDBActionManager.java	Thu Apr 02 13:20:49 2015 -0700
@@ -32,10 +32,12 @@
 public class HSDBActionManager extends ActionManager {
 
     public static ActionManager getInstance() {
-        if (manager == null) {
-            manager = new HSDBActionManager();
+        ActionManager m = ActionManager.getInstance();
+        if (m == null) {
+            m = new HSDBActionManager();
+            ActionManager.setInstance(m);
         }
-        return manager;
+        return m;
     }
 
     protected void addActions() {