changeset 324:ca063536e4a6

6593082: MirroredTypeException constructor does not throw NPE when type is null Reviewed-by: jjg
author darcy
date Fri, 26 Jun 2009 12:22:40 -0700
parents 812d5486a023
children 03944ee4fac4
files src/share/classes/javax/lang/model/type/MirroredTypeException.java test/tools/javac/processing/model/type/MirroredTypeEx/NpeTest.java
diffstat 2 files changed, 43 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/src/share/classes/javax/lang/model/type/MirroredTypeException.java	Wed Jun 24 17:34:13 2009 -0700
+++ b/src/share/classes/javax/lang/model/type/MirroredTypeException.java	Fri Jun 26 12:22:40 2009 -0700
@@ -54,7 +54,7 @@
      * @param type  the type being accessed
      */
     public MirroredTypeException(TypeMirror type) {
-        super("Attempt to access Class object for TypeMirror " + type);
+        super("Attempt to access Class object for TypeMirror " + type.toString());
         this.type = type;
     }
 
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/test/tools/javac/processing/model/type/MirroredTypeEx/NpeTest.java	Fri Jun 26 12:22:40 2009 -0700
@@ -0,0 +1,42 @@
+/*
+ * Copyright 2009 Sun Microsystems, Inc.  All Rights Reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
+ * CA 95054 USA or visit www.sun.com if you need additional information or
+ * have any questions.
+ */
+
+/*
+ * @test
+ * @bug     6593082
+ * @summary MirroredTypeException constructor should not accept null
+ * @author  Joseph D. Darcy
+ */
+
+import javax.lang.model.type.*;
+
+public class NpeTest  {
+    public static void main(String... args) {
+        try {
+            MirroredTypeException mte = new MirroredTypeException(null);
+            throw new RuntimeException("Expected NPE not thrown.");
+        } catch (NullPointerException npe) {
+            ; // success
+        }
+    }
+}