changeset 12674:5349781383fa

8129789: implies() of ServicePermission and DelegationPermission underspecified Reviewed-by: mullan
author weijun
date Wed, 02 Sep 2015 19:20:46 +0800
parents 155ddfb406fd
children d9bd64884486
files src/java.security.jgss/share/classes/javax/security/auth/kerberos/DelegationPermission.java src/java.security.jgss/share/classes/javax/security/auth/kerberos/ServicePermission.java
diffstat 2 files changed, 13 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/src/java.security.jgss/share/classes/javax/security/auth/kerberos/DelegationPermission.java	Wed Sep 02 03:02:14 2015 +0000
+++ b/src/java.security.jgss/share/classes/javax/security/auth/kerberos/DelegationPermission.java	Wed Sep 02 19:20:46 2015 +0800
@@ -132,7 +132,9 @@
      * Checks if this Kerberos delegation permission object "implies" the
      * specified permission.
      * <P>
-     * If none of the above are true, {@code implies} returns false.
+     * This method returns true if this {@code DelegationPermission}
+     * is equal to {@code p}, and returns false otherwise.
+     *
      * @param p the permission to check against.
      *
      * @return true if the specified permission is implied by this object,
--- a/src/java.security.jgss/share/classes/javax/security/auth/kerberos/ServicePermission.java	Wed Sep 02 03:02:14 2015 +0000
+++ b/src/java.security.jgss/share/classes/javax/security/auth/kerberos/ServicePermission.java	Wed Sep 02 19:20:46 2015 +0800
@@ -179,7 +179,16 @@
      * Checks if this Kerberos service permission object "implies" the
      * specified permission.
      * <P>
-     * If none of the above are true, {@code implies} returns false.
+     * More specifically, this method returns true if all of the following
+     * are true (and returns false if any of them are not):
+     * <ul>
+     * <li> <i>p</i> is an instanceof {@code ServicePermission},
+     * <li> <i>p</i>'s actions are a proper subset of this
+     * {@code ServicePermission}'s actions,
+     * <li> <i>p</i>'s name is equal to this {@code ServicePermission}'s name
+     * or this {@code ServicePermission}'s name is "*".
+     * </ul>
+     *
      * @param p the permission to check against.
      *
      * @return true if the specified permission is implied by this object,