changeset 1137:4546bb1275b5

7901312: JMH fails with -XX:-StackTraceInThrowable
author shade
date Thu, 19 Feb 2015 21:57:19 +0300
parents bab1bf789b5b
children 1ff6f05a9e8d
files jmh-core-it/src/test/java/org/openjdk/jmh/it/StackTraceInThrowableTest.java jmh-core/src/main/java/org/openjdk/jmh/infra/Blackhole.java
diffstat 2 files changed, 79 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/jmh-core-it/src/test/java/org/openjdk/jmh/it/StackTraceInThrowableTest.java	Thu Feb 19 21:57:19 2015 +0300
@@ -0,0 +1,71 @@
+/*
+ * Copyright (c) 2005, 2013, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.  Oracle designates this
+ * particular file as subject to the "Classpath" exception as provided
+ * by Oracle in the LICENSE file that accompanied this code.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+package org.openjdk.jmh.it;
+
+import org.junit.Assert;
+import org.junit.Test;
+import org.openjdk.jmh.annotations.Benchmark;
+import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Fork;
+import org.openjdk.jmh.annotations.Level;
+import org.openjdk.jmh.annotations.Measurement;
+import org.openjdk.jmh.annotations.Mode;
+import org.openjdk.jmh.annotations.Scope;
+import org.openjdk.jmh.annotations.Setup;
+import org.openjdk.jmh.annotations.State;
+import org.openjdk.jmh.annotations.TearDown;
+import org.openjdk.jmh.annotations.Warmup;
+import org.openjdk.jmh.runner.Runner;
+import org.openjdk.jmh.runner.RunnerException;
+import org.openjdk.jmh.runner.options.Options;
+import org.openjdk.jmh.runner.options.OptionsBuilder;
+
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicInteger;
+
+
+@State(Scope.Thread)
+public class StackTraceInThrowableTest {
+
+    @Benchmark
+    @BenchmarkMode(Mode.All)
+    @Warmup(iterations = 0)
+    @Measurement(iterations = 1, time = 1, timeUnit = TimeUnit.MILLISECONDS)
+    @Fork(1)
+    public void test() {
+        Fixtures.work();
+    }
+
+    @Test
+    public void invokeAPI() throws RunnerException {
+        Options opts = new OptionsBuilder()
+                .include(Fixtures.getTestMask(this.getClass()))
+                .shouldFailOnError(true)
+                .jvmArgs("-XX:-StackTraceInThrowable")
+                .build();
+        new Runner(opts).run();
+    }
+
+}
--- a/jmh-core/src/main/java/org/openjdk/jmh/infra/Blackhole.java	Wed Feb 18 21:08:07 2015 +0300
+++ b/jmh-core/src/main/java/org/openjdk/jmh/infra/Blackhole.java	Thu Feb 19 21:57:19 2015 +0300
@@ -261,7 +261,14 @@
          */
 
         IllegalStateException iae = new IllegalStateException("Blackholes should not be instantiated directly.");
-        for (StackTraceElement el : iae.getStackTrace()) {
+        StackTraceElement[] stackTrace = iae.getStackTrace();
+
+        // Somebody disabled the stack traces? Oh well.
+        if (stackTrace.length == 0) {
+            return;
+        }
+
+        for (StackTraceElement el : stackTrace) {
             // Either we instantiate from the JMH generated code,
             // or our user is a tricky bastard, and gets what's coming to him.
             if (el.getMethodName().startsWith("_jmh_tryInit_") &&