changeset 48302:50181ff45d46

8191360: Lookup of critical JNI method causes duplicate library loading with leaking handler Summary: Unload shared library after lookup to avoid keeping it live. Reviewed-by: vlivanov, dholmes
author thartmann
date Tue, 05 Dec 2017 08:27:54 +0100
parents 32f13c6c1bbd
children 43064ad4a21e
files src/hotspot/share/prims/nativeLookup.cpp test/jdk/java/lang/ClassLoader/nativeLibrary/NativeLibraryTest.java
diffstat 2 files changed, 8 insertions(+), 3 deletions(-) [+]
line wrap: on
line diff
--- a/src/hotspot/share/prims/nativeLookup.cpp	Mon Dec 04 10:23:08 2017 +0900
+++ b/src/hotspot/share/prims/nativeLookup.cpp	Tue Dec 05 08:27:54 2017 +0100
@@ -224,7 +224,13 @@
       st.print_raw(long_name);
       if (os_style) os::print_jni_name_suffix_on(&st, args_size);
       char* jni_name = st.as_string();
-      return (address)os::dll_lookup(dll, jni_name);
+      address critical_entry = (address)os::dll_lookup(dll, jni_name);
+      // Close the handle to avoid keeping the library alive if the native method holder is unloaded.
+      // This is fine because the library is still kept alive by JNI (see JVM_LoadLibrary). As soon
+      // as the holder class and the library are unloaded (see JVM_UnloadLibrary), the native wrapper
+      // that calls 'critical_entry' becomes unreachable and is unloaded as well.
+      os::dll_unload(dll);
+      return critical_entry;
     }
   }
 
@@ -245,7 +251,6 @@
                 + (method->is_static() ? 1 : 0) // class for static methods
                 + method->size_of_parameters(); // actual parameters
 
-
   // 1) Try JNI short style
   entry = lookup_style(method, pure_name, "",        args_size, true,  in_base_library, CHECK_NULL);
   if (entry != NULL) return entry;
--- a/test/jdk/java/lang/ClassLoader/nativeLibrary/NativeLibraryTest.java	Mon Dec 04 10:23:08 2017 +0900
+++ b/test/jdk/java/lang/ClassLoader/nativeLibrary/NativeLibraryTest.java	Tue Dec 05 08:27:54 2017 +0100
@@ -23,7 +23,7 @@
 
 /*
  * @test
- * @bug 8164512
+ * @bug 8164512 8191360
  * @summary verify if the native library is unloaded when the class loader is GC'ed
  * @build p.Test
  * @run main/othervm/native -Xcheck:jni NativeLibraryTest