changeset 50145:752645a158ff

8198412: MonospacedGlyphWidthTest.java may fail on Solaris Reviewed-by: serb
author prr
date Fri, 11 May 2018 20:59:21 -0700
parents 2a85d59e7f8b
children 0bb0e464ee76
files test/jdk/ProblemList.txt test/jdk/java/awt/font/MonospacedGlyphWidth/MonospacedGlyphWidthTest.java
diffstat 2 files changed, 42 insertions(+), 10 deletions(-) [+]
line wrap: on
line diff
--- a/test/jdk/ProblemList.txt	Fri May 11 15:27:51 2018 -0700
+++ b/test/jdk/ProblemList.txt	Fri May 11 20:59:21 2018 -0700
@@ -221,7 +221,6 @@
 java/awt/Window/GrabSequence/GrabSequence.java 6848409 macosx-all,linux-all
 java/awt/font/TextLayout/CombiningPerf.java 8192931 generic-all
 java/awt/font/TextLayout/TextLayoutBounds.java 8169188 generic-all
-java/awt/font/MonospacedGlyphWidth/MonospacedGlyphWidthTest.java 8198412 linux-all,solaris-all
 java/awt/font/StyledMetrics/BoldSpace.java 8198422 linux-all
 java/awt/FontMetrics/FontCrash.java 8198336 windows-all
 java/awt/image/DrawImage/IncorrectAlphaSurface2SW.java 8056077 generic-all
--- a/test/jdk/java/awt/font/MonospacedGlyphWidth/MonospacedGlyphWidthTest.java	Fri May 11 15:27:51 2018 -0700
+++ b/test/jdk/java/awt/font/MonospacedGlyphWidth/MonospacedGlyphWidthTest.java	Fri May 11 20:59:21 2018 -0700
@@ -22,33 +22,66 @@
  */
 
 /* @test
- * @bug 8073400
+ * @bug 8073400 8198412
  * @summary Some Monospaced logical fonts have a different width
  * @author Dmitry Markov
  * @run main MonospacedGlyphWidthTest
  */
-import java.awt.*;
+import java.awt.Font;
+import java.awt.GraphicsEnvironment;
 import java.awt.font.FontRenderContext;
 
 public class MonospacedGlyphWidthTest {
-    private static final int START_INDEX = 0x2018;
-    private static final int END_INDEX = 0x201F;
+    private static final int ASCII_START_INDEX = 0x0061;
+    private static final int ASCII_END_INDEX = 0x007A;
 
-    public static void main(String[] args) {
+    private static final int TEST_START_INDEX = 0x2018;
+    private static final int TEST_END_INDEX = 0x201F;
+
+    private static boolean checkChars(int start, int end, boolean except) {
         Font font = new Font(Font.MONOSPACED, Font.PLAIN, 12);
         double width = getCharWidth(font, 'a');
 
-        for (int i = START_INDEX; i <= END_INDEX; i++) {
+        for (int i = start; i <= end; i++) {
+            if (!(font.canDisplay(i))) {
+                if (except) {
+                    continue;
+                } else {
+                    return false;
+                }
+            }
             if (width != getCharWidth(font, (char)i)) {
-                throw new RuntimeException("Test Failed: characters have different width!");
+                if (except) {
+                    throw new RuntimeException(
+                          "Test Failed: characters have different width!");
+                } else {
+                    return false;
+                }
             }
         }
-        System.out.println("Test Passed!");
+        return true;
     }
 
     private static double getCharWidth(Font font, char c) {
         FontRenderContext fontRenderContext = new FontRenderContext(null, false, false);
         return font.getStringBounds(new char[] {c}, 0, 1, fontRenderContext).getWidth();
     }
+
+    public static void main(String[] args) {
+        if (!checkChars(ASCII_START_INDEX, ASCII_END_INDEX, false)) {
+           System.out.println("It appears there are no suitable fonts");
+           System.out.println("Here are the fonts found on this system:");
+           GraphicsEnvironment ge =
+               GraphicsEnvironment.getLocalGraphicsEnvironment();
+           Font[] fonts = ge.getAllFonts();
+           for (Font f : fonts) {
+               System.out.println(f);
+           }
+
+           return;
+        }
+
+        checkChars(TEST_START_INDEX, TEST_END_INDEX, true);
+        System.out.println("Test Passed!");
+    }
 }
-