changeset 59451:8bc0c41c3ec0

8245723: Remove PrintCompressedOopsMode and change gc+heap+coops info log to debug level Reviewed-by: dholmes, coleenp, tschatzl
author sjohanss
date Wed, 27 May 2020 11:48:13 +0200
parents 5518622bebe0
children 47d6fee210ed
files src/hotspot/share/oops/compressedOops.cpp src/hotspot/share/runtime/arguments.cpp test/hotspot/jtreg/runtime/CompressedOops/CompressedClassPointers.java test/hotspot/jtreg/runtime/logging/CompressedOopsTest.java
diffstat 4 files changed, 11 insertions(+), 18 deletions(-) [+]
line wrap: on
line diff
--- a/src/hotspot/share/oops/compressedOops.cpp	Wed May 27 09:22:24 2020 +0200
+++ b/src/hotspot/share/oops/compressedOops.cpp	Wed May 27 11:48:13 2020 +0200
@@ -66,7 +66,7 @@
 
   _heap_address_range = heap_space.region();
 
-  LogTarget(Info, gc, heap, coops) lt;
+  LogTarget(Debug, gc, heap, coops) lt;
   if (lt.is_enabled()) {
     ResourceMark rm;
     LogStream ls(lt);
--- a/src/hotspot/share/runtime/arguments.cpp	Wed May 27 09:22:24 2020 +0200
+++ b/src/hotspot/share/runtime/arguments.cpp	Wed May 27 11:48:13 2020 +0200
@@ -602,7 +602,6 @@
 
 // NOTE: A compatibility request will be necessary for each alias to be removed.
 static AliasedLoggingFlag const aliased_logging_flags[] = {
-  { "PrintCompressedOopsMode",   LogLevel::Info,  true,  LOG_TAGS(gc, heap, coops) },
   { "PrintSharedSpaces",         LogLevel::Info,  true,  LOG_TAGS(cds) },
   { "TraceBiasedLocking",        LogLevel::Info,  true,  LOG_TAGS(biasedlocking) },
   { "TraceClassLoading",         LogLevel::Info,  true,  LOG_TAGS(class, load) },
--- a/test/hotspot/jtreg/runtime/CompressedOops/CompressedClassPointers.java	Wed May 27 09:22:24 2020 +0200
+++ b/test/hotspot/jtreg/runtime/CompressedOops/CompressedClassPointers.java	Wed May 27 11:48:13 2020 +0200
@@ -154,9 +154,9 @@
             "-XX:SharedArchiveFile=./CompressedClassPointers.jsa",
             "-Xmx128m",
             "-XX:SharedBaseAddress=8g",
-            "-XX:+PrintCompressedOopsMode",
             "-XX:+VerifyBeforeGC",
-            "-Xshare:dump", "-Xlog:cds");
+            "-Xshare:dump",
+            "-Xlog:cds,gc+heap+coops=debug");
         OutputAnalyzer output = new OutputAnalyzer(pb.start());
         if (output.firstMatch("Shared spaces are not supported in this VM") != null) {
             return;
@@ -170,7 +170,7 @@
             "-XX:SharedArchiveFile=./CompressedClassPointers.jsa",
             "-Xmx128m",
             "-XX:SharedBaseAddress=8g",
-            "-XX:+PrintCompressedOopsMode",
+            "-Xlog:gc+heap+coops=debug",
             "-Xshare:on",
             "-version");
           output = new OutputAnalyzer(pb.start());
@@ -269,9 +269,9 @@
             "-XX:SharedArchiveFile=./CompressedClassPointers.jsa",
             "-Xmx128m",
             "-XX:SharedBaseAddress=8g",
-            "-XX:+PrintCompressedOopsMode",
             "-XX:+VerifyBeforeGC",
-            "-Xshare:dump", "-Xlog:cds");
+            "-Xshare:dump",
+            "-Xlog:cds,gc+heap+coops=debug");
         OutputAnalyzer output = new OutputAnalyzer(pb.start());
         if (output.firstMatch("Shared spaces are not supported in this VM") != null) {
             return;
@@ -287,7 +287,7 @@
             "-XX:SharedArchiveFile=./CompressedClassPointers.jsa",
             "-Xmx128m",
             "-XX:SharedBaseAddress=8g",
-            "-XX:+PrintCompressedOopsMode",
+            "-Xlog:gc+heap+coops=debug",
             "-Xshare:on",
             "-version");
           output = new OutputAnalyzer(pb.start());
--- a/test/hotspot/jtreg/runtime/logging/CompressedOopsTest.java	Wed May 27 09:22:24 2020 +0200
+++ b/test/hotspot/jtreg/runtime/logging/CompressedOopsTest.java	Wed May 27 11:48:13 2020 +0200
@@ -51,24 +51,18 @@
 
     public static void main(String[] args) throws Exception {
         ProcessBuilder pb = ProcessTools.createJavaProcessBuilder("-XX:+UseCompressedOops",
-                                                   "-Xlog:gc+heap+coops=info",
+                                                   "-Xlog:gc+heap+coops=debug",
                                                    InnerClass.class.getName());
         analyzeOutputOn(pb);
 
         pb = ProcessTools.createJavaProcessBuilder("-XX:+UseCompressedOops",
-                                                   "-XX:+PrintCompressedOopsMode",
+                                                   "-Xlog:gc+heap+coops",
                                                    InnerClass.class.getName());
-        analyzeOutputOn(pb);
-
-        pb = ProcessTools.createJavaProcessBuilder("-XX:+UseCompressedOops",
-                                                   "-XX:+PrintCompressedOopsMode",
-                                                   "-Xlog:gc+heap+coops=off",
-                                                   InnerClass.class.getName());
+        // No coops logging on info level.
         analyzeOutputOff(pb);
 
         pb = ProcessTools.createJavaProcessBuilder("-XX:+UseCompressedOops",
-                                                   "-Xlog:gc+heap+coops=info",
-                                                   "-XX:-PrintCompressedOopsMode",
+                                                   "-Xlog:gc+heap+coops=off",
                                                    InnerClass.class.getName());
         analyzeOutputOff(pb);
     }