changeset 46823:d38520dd1ec3

8186293: [aix] Fix thread creation with huge stack sizes Reviewed-by: stuefe, dholmes
author goetz
date Wed, 16 Aug 2017 16:00:15 +0200
parents 5778a97eb82f
children 9e13f4eb7670
files hotspot/src/os/aix/vm/os_aix.cpp
diffstat 1 files changed, 19 insertions(+), 8 deletions(-) [+]
line wrap: on
line diff
--- a/hotspot/src/os/aix/vm/os_aix.cpp	Wed Aug 16 20:57:00 2017 +0000
+++ b/hotspot/src/os/aix/vm/os_aix.cpp	Wed Aug 16 16:00:15 2017 +0200
@@ -863,20 +863,31 @@
 
   // Calculate stack size if it's not specified by caller.
   size_t stack_size = os::Posix::get_initial_stack_size(thr_type, req_stack_size);
-  int status = pthread_attr_setstacksize(&attr, stack_size);
-  assert_status(status == 0, status, "pthread_attr_setstacksize");
+
+  // On Aix, pthread_attr_setstacksize fails with huge values and leaves the
+  // thread size in attr unchanged. If this is the minimal stack size as set
+  // by pthread_attr_init this leads to crashes after thread creation. E.g. the
+  // guard pages might not fit on the tiny stack created.
+  int ret = pthread_attr_setstacksize(&attr, stack_size);
+  if (ret != 0) {
+    log_warning(os, thread)("The thread stack size specified is invalid: " SIZE_FORMAT "k",
+                            stack_size / K);
+  }
 
   // Configure libc guard page.
-  pthread_attr_setguardsize(&attr, os::Aix::default_guard_size(thr_type));
-
-  pthread_t tid;
-  int ret = pthread_create(&tid, &attr, (void* (*)(void*)) thread_native_entry, thread);
-
-  char buf[64];
+  ret = pthread_attr_setguardsize(&attr, os::Aix::default_guard_size(thr_type));
+
+  pthread_t tid = 0;
   if (ret == 0) {
+    ret = pthread_create(&tid, &attr, (void* (*)(void*)) thread_native_entry, thread);
+  }
+
+  if (ret == 0) {
+    char buf[64];
     log_info(os, thread)("Thread started (pthread id: " UINTX_FORMAT ", attributes: %s). ",
       (uintx) tid, os::Posix::describe_pthread_attr(buf, sizeof(buf), &attr));
   } else {
+    char buf[64];
     log_warning(os, thread)("Failed to start thread - pthread_create failed (%d=%s) for attributes: %s.",
       ret, os::errno_name(ret), os::Posix::describe_pthread_attr(buf, sizeof(buf), &attr));
   }