6944822: Fix for 6938627 exposes problem with hard-coded buffer sizes
authorcoleenp
Mon Apr 19 18:58:31 2010 -0400 (3 years ago)
changeset 171496d554193f72
parent 16506ccd32c284ac
child 171577261afdc5f2
6944822: Fix for 6938627 exposes problem with hard-coded buffer sizes
Summary: Make tmpdir buffer sizes MAX_PATH+1
Reviewed-by: dholmes, coleenp
Contributed-by: andreas.kohn@fredhopper.com
src/os/linux/vm/attachListener_linux.cpp
src/os/linux/vm/os_linux.cpp
src/os/solaris/vm/attachListener_solaris.cpp
--- a/src/os/linux/vm/attachListener_linux.cpp Wed Apr 07 12:28:22 2010 -0400
+++ b/src/os/linux/vm/attachListener_linux.cpp Mon Apr 19 18:58:31 2010 -0400
@@ -461,7 +461,7 @@ bool AttachListener::is_init_trigger() {
if (init_at_startup() || is_initialized()) {
return false; // initialized at startup or already initialized
}
- char fn[128];
+ char fn[PATH_MAX+1];
sprintf(fn, ".attach_pid%d", os::current_process_id());
int ret;
struct stat64 st;
--- a/src/os/linux/vm/os_linux.cpp Wed Apr 07 12:28:22 2010 -0400
+++ b/src/os/linux/vm/os_linux.cpp Mon Apr 19 18:58:31 2010 -0400
@@ -2305,7 +2305,7 @@ void linux_wrap_code(char* base, size_t
return;
}
- char buf[40];
+ char buf[PATH_MAX+1];
int num = Atomic::add(1, &cnt);
snprintf(buf, sizeof(buf), "%s/hs-vm-%d-%d",
--- a/src/os/solaris/vm/attachListener_solaris.cpp Wed Apr 07 12:28:22 2010 -0400
+++ b/src/os/solaris/vm/attachListener_solaris.cpp Mon Apr 19 18:58:31 2010 -0400
@@ -592,7 +592,7 @@ bool AttachListener::is_init_trigger() {
if (init_at_startup() || is_initialized()) {
return false; // initialized at startup or already initialized
}
- char fn[128];
+ char fn[PATH_MAX+1];
sprintf(fn, ".attach_pid%d", os::current_process_id());
int ret;
struct stat64 st;