6674232: OPENJDK=false is same as OPENJDK=true
authorohair
Tue Mar 18 11:01:40 2008 -0700 (2 years ago)
changeset 705809a7eb190
parent 6f769c64f71ac
child 8cbc8ad9dd0e0
6674232: OPENJDK=false is same as OPENJDK=true
Summary: If OPENJDK has a value, that value must be "true", empty value == undefined with GNU make.
Reviewed-by: tbell
make/Defs-internal.gmk
--- a/make/Defs-internal.gmk Thu Mar 13 16:12:15 2008 -0700
+++ b/make/Defs-internal.gmk Tue Mar 18 11:01:40 2008 -0700
@@ -27,6 +27,12 @@
# Common variables used by all the Java makefiles. This file should
# not contain rules.
#
+
+ifdef OPENJDK
+ ifneq ($(OPENJDK),true)
+ x:=$(error "OPENJDK (if defined) can only be set to true")
+ endif
+endif
# Define absolute paths to TOPDIRs
ABS_CONTROL_TOPDIR:=$(call OptFullPath,"$(CONTROL_TOPDIR)")
@@ -96,10 +102,8 @@ endif
endif
ifeq ($(JDK_SRC_AVAILABLE),true)
JDK_CLOSED_SRC_AVAILABLE := $(call MkExists,$(JDK_TOPDIR)/src/closed)
- ifndef OPENJDK
- ifeq ($(JDK_CLOSED_SRC_AVAILABLE),false)
- OPENJDK = true
- endif
+ ifeq ($(JDK_CLOSED_SRC_AVAILABLE),false)
+ OPENJDK = true
endif
endif