changeset 4301:0a5dbad3cd92

8010227: Remove promotion failed boolean from YC event Summary: Remove promotion failed boolean from YC event Reviewed-by: dholmes, brutisso
author jwilhelm
date Tue, 19 Mar 2013 18:32:16 +0100
parents 893fd4dc2d3b
children 47b5859d4634
files src/share/vm/gc_implementation/shared/gcTrace.cpp src/share/vm/gc_implementation/shared/gcTrace.hpp src/share/vm/gc_implementation/shared/gcTraceSend.cpp src/share/vm/trace/trace.xml
diffstat 4 files changed, 0 insertions(+), 17 deletions(-) [+]
line wrap: on
line diff
--- a/src/share/vm/gc_implementation/shared/gcTrace.cpp	Mon Mar 18 10:21:11 2013 -0700
+++ b/src/share/vm/gc_implementation/shared/gcTrace.cpp	Tue Mar 19 18:32:16 2013 +0100
@@ -101,7 +101,6 @@
 void YoungGCTracer::report_promotion_failed(size_t size, uint count) {
   assert_set_gc_id();
 
-  young_gc_info().register_promotion_failed();
   send_promotion_failed_event(size, count);
 }
 
--- a/src/share/vm/gc_implementation/shared/gcTrace.hpp	Mon Mar 18 10:21:11 2013 -0700
+++ b/src/share/vm/gc_implementation/shared/gcTrace.hpp	Tue Mar 19 18:32:16 2013 +0100
@@ -93,16 +93,6 @@
   void* dense_prefix() const { return _dense_prefix; }
 };
 
-class YoungGCInfo VALUE_OBJ_CLASS_SPEC {
-  bool _promotion_failed;
- public:
-  YoungGCInfo() : _promotion_failed(false) {}
-  void register_promotion_failed() {
-    _promotion_failed = true;
-  }
-  bool promotion_failed() const { return _promotion_failed; }
-};
-
 #ifndef SERIALGC
 
 class G1YoungGCInfo VALUE_OBJ_CLASS_SPEC {
@@ -143,11 +133,8 @@
 };
 
 class YoungGCTracer : public GCTracer {
-  YoungGCInfo _young_gc_info;
-
  protected:
   YoungGCTracer(GCName name) : GCTracer(name) {}
-  virtual YoungGCInfo& young_gc_info() { return _young_gc_info; }
 
  public:
   virtual void report_promotion_failed(size_t size, uint count);
--- a/src/share/vm/gc_implementation/shared/gcTraceSend.cpp	Mon Mar 18 10:21:11 2013 -0700
+++ b/src/share/vm/gc_implementation/shared/gcTraceSend.cpp	Tue Mar 19 18:32:16 2013 +0100
@@ -75,7 +75,6 @@
   EventGCYoungGarbageCollection e(UNTIMED);
   if (e.should_commit()) {
     e.set_gcId(_shared_gc_info.id());
-    e.set_promotionFailed(_young_gc_info.promotion_failed());
     e.set_starttime(_shared_gc_info.start_timestamp());
     e.set_endtime(_shared_gc_info.end_timestamp());
     e.commit();
--- a/src/share/vm/trace/trace.xml	Mon Mar 18 10:21:11 2013 -0700
+++ b/src/share/vm/trace/trace.xml	Tue Mar 19 18:32:16 2013 +0100
@@ -168,8 +168,6 @@
     <event id="GCYoungGarbageCollection" path="vm/gc/collector/young_garbage_collection" label="Young Garbage Collection"
            description="Extra information specific to Young Garbage Collections">
       <value type="ULONG" field="gcId"  label="GC ID" relation="GC_ID" />
-      <!-- This information can also be found by looking for PromotionFailed events. It's here for convenience. -->
-      <value type="BOOLEAN" field="promotionFailed" label="Promotion Failed" description="Tells if we failed to promote some objects to the old gen" />
     </event>
 
     <event id="GCOldGarbageCollection" path="vm/gc/collector/old_garbage_collection" label="Old Garbage Collection"