OpenJDK / jdk8u / jdk8u / jdk
changeset 10798:b26427c5b3fe
8068886: IDEA IntelliJ crashes in objc_msgSend when an accessibility tool is enabled
Reviewed-by: serb, bae
author | anashaty |
---|---|
date | Thu, 04 Jun 2015 16:32:34 +0300 |
parents | db989e88ef7f |
children | 159ccfdc37f7 |
files | src/macosx/native/sun/awt/CFRetainedResource.m src/macosx/native/sun/awt/LWCToolkit.m src/macosx/native/sun/osxapp/NSApplicationAWT.h src/macosx/native/sun/osxapp/NSApplicationAWT.m src/share/classes/sun/awt/datatransfer/DataTransferer.java |
diffstat | 5 files changed, 48 insertions(+), 10 deletions(-) [+] |
line wrap: on
line diff
--- a/src/macosx/native/sun/awt/CFRetainedResource.m Thu Jun 04 15:29:07 2015 +0300 +++ b/src/macosx/native/sun/awt/CFRetainedResource.m Thu Jun 04 16:32:34 2015 +0300 @@ -23,6 +23,7 @@ * questions. */ +#import <Cocoa/Cocoa.h> #import <JavaNativeFoundation/JavaNativeFoundation.h> #import "sun_lwawt_macosx_CFRetainedResource.h" @@ -37,7 +38,10 @@ (JNIEnv *env, jclass clazz, jlong ptr, jboolean releaseOnAppKitThread) { if (releaseOnAppKitThread) { - [JNFRunLoop performOnMainThreadWaiting:NO withBlock:^(){ + // Releasing resources on the main AppKit message loop only + // Releasing resources on the nested loops may cause dangling + // pointers after the nested loop is exited + [NSApp postRunnableEvent:^(){ CFRelease(jlong_to_ptr(ptr)); }]; } else {
--- a/src/macosx/native/sun/awt/LWCToolkit.m Thu Jun 04 15:29:07 2015 +0300 +++ b/src/macosx/native/sun/awt/LWCToolkit.m Thu Jun 04 16:32:34 2015 +0300 @@ -339,8 +339,10 @@ beforeDate:[NSDate dateWithTimeIntervalSinceNow:0.010]]; if (processEvents) { //We do not spin a runloop here as date is nil, so does not matter which mode to use + // Processing all events excluding NSApplicationDefined which need to be processed + // on the main loop only (those events are intended for disposing resources) NSEvent *event; - if ((event = [NSApp nextEventMatchingMask:NSAnyEventMask + if ((event = [NSApp nextEventMatchingMask:(NSAnyEventMask & ~NSApplicationDefined) untilDate:nil inMode:NSDefaultRunLoopMode dequeue:YES]) != nil) {
--- a/src/macosx/native/sun/osxapp/NSApplicationAWT.h Thu Jun 04 15:29:07 2015 +0300 +++ b/src/macosx/native/sun/osxapp/NSApplicationAWT.h Thu Jun 04 16:32:34 2015 +0300 @@ -37,6 +37,7 @@ - (void) registerWithProcessManager; - (void) setDockIconWithEnv:(JNIEnv *)env; - (void) postDummyEvent; +- (void) postRunnableEvent:(void (^)())block; - (void) waitForDummyEvent; + (void) runAWTLoopWithApp:(NSApplication*)app;
--- a/src/macosx/native/sun/osxapp/NSApplicationAWT.m Thu Jun 04 15:29:07 2015 +0300 +++ b/src/macosx/native/sun/osxapp/NSApplicationAWT.m Thu Jun 04 16:32:34 2015 +0300 @@ -338,9 +338,13 @@ - (void)sendEvent:(NSEvent *)event { - if ([event type] == NSApplicationDefined && TS_EQUAL([event timestamp], dummyEventTimestamp)) { + if ([event type] == NSApplicationDefined && TS_EQUAL([event timestamp], dummyEventTimestamp) && [event subtype] == 0) { [seenDummyEventLock lockWhenCondition:NO]; [seenDummyEventLock unlockWithCondition:YES]; + } else if ([event type] == NSApplicationDefined && [event subtype] == 777) { + void (^block)() = (void (^)()) [event data1]; + block(); + [block release]; } else if ([event type] == NSKeyUp && ([event modifierFlags] & NSCommandKeyMask)) { // Cocoa won't send us key up event when releasing a key while Cmd is down, // so we have to do it ourselves. @@ -350,6 +354,33 @@ } } +/* + * Posts the block to the AppKit event queue which will be executed + * on the main AppKit loop. + * While running nested loops this event will be ignored. + */ +- (void)postRunnableEvent:(void (^)())block +{ + void (^copy)() = [block copy]; + NSInteger encode = (NSInteger) copy; + [copy retain]; + NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init]; + NSEvent* event = [NSEvent otherEventWithType: NSApplicationDefined + location: NSMakePoint(0,0) + modifierFlags: 0 + timestamp: 0 + windowNumber: 0 + context: nil + subtype: 777 + data1: encode + data2: 0]; + + [NSApp postEvent: event atStart: NO]; + [pool drain]; +} + + + - (void)postDummyEvent { seenDummyEventLock = [[NSConditionLock alloc] initWithCondition:NO]; dummyEventTimestamp = [NSProcessInfo processInfo].systemUptime;
--- a/src/share/classes/sun/awt/datatransfer/DataTransferer.java Thu Jun 04 15:29:07 2015 +0300 +++ b/src/share/classes/sun/awt/datatransfer/DataTransferer.java Thu Jun 04 16:32:34 2015 +0300 @@ -2905,13 +2905,13 @@ return comp; } - if (flavor1.isFlavorTextType()) { - return 1; - } - - if (flavor2.isFlavorTextType()) { - return -1; - } +// if (flavor1.isFlavorTextType()) { +// return 1; +// } +// +// if (flavor2.isFlavorTextType()) { +// return -1; +// } // Next, look for application/x-java-* types. Prefer unknown // MIME types because if the user provides his own data flavor,