changeset 1905:c06c491eff67

6550546: Win LAF: JFileChooser -> Look in Drop down should not display any shortcuts created on desktop Reviewed-by: peterz
author rupashka
date Thu, 22 Oct 2009 16:39:29 +0400
parents e1cd8b6d8e3c
children 65da4a7fbf7f
files src/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java test/javax/swing/JFileChooser/6550546/bug6550546.java
diffstat 2 files changed, 58 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/src/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java	Thu Oct 22 15:43:25 2009 +0400
+++ b/src/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java	Thu Oct 22 16:39:29 2009 +0400
@@ -269,7 +269,7 @@
                 Arrays.sort(secondLevelFolders);
                 for (File secondLevelFolder : secondLevelFolders) {
                     Win32ShellFolder2 folder = (Win32ShellFolder2) secondLevelFolder;
-                    if (!folder.isFileSystem() || folder.isDirectory()) {
+                    if (!folder.isFileSystem() || (folder.isDirectory() && !folder.isLink())) {
                         folders.add(folder);
                         // Add third level for "My Computer"
                         if (folder.equals(drives)) {
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/test/javax/swing/JFileChooser/6550546/bug6550546.java	Thu Oct 22 16:39:29 2009 +0400
@@ -0,0 +1,57 @@
+/*
+ * Copyright 2009 Sun Microsystems, Inc.  All Rights Reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
+ * CA 95054 USA or visit www.sun.com if you need additional information or
+ * have any questions.
+ */
+
+/* @test
+   @bug 6550546
+   @summary Win LAF: JFileChooser -> Look in Drop down should not display any shortcuts created on desktop
+   @author Pavel Porvatov
+   @run main bug6550546
+*/
+
+import sun.awt.OSInfo;
+import sun.awt.shell.ShellFolder;
+
+import javax.swing.*;
+import java.io.File;
+
+public class bug6550546 {
+    public static void main(String[] args) throws Exception {
+        if (OSInfo.getOSType() != OSInfo.OSType.WINDOWS) {
+            System.out.println("The test is suitable only for Windows, skipped.");
+
+            return;
+        }
+
+        SwingUtilities.invokeAndWait(new Runnable() {
+            public void run() {
+                File[] files = (File[]) ShellFolder.get("fileChooserComboBoxFolders");
+
+                for (File file : files) {
+                    if (file instanceof ShellFolder && ((ShellFolder) file).isLink()) {
+                        throw new RuntimeException("Link shouldn't be in FileChooser combobox, " + file.getPath());
+                    }
+                }
+            }
+        });
+    }
+}