changeset 10280:fa78bfad29f4

8058193: [macosx] Potential incomplete fix for JDK-8031485 Reviewed-by: alexsch, serb
author pchelko
date Wed, 19 Nov 2014 18:57:39 +0400
parents 736dc97f9db5
children b0e7095469b3
files src/macosx/classes/com/apple/laf/AquaComboBoxUI.java test/javax/swing/JComboBox/ConsumedEscTest/ConsumedEscTest.java test/javax/swing/JComboBox/ConsumedKeyTest/ConsumedKeyTest.java
diffstat 3 files changed, 100 insertions(+), 89 deletions(-) [+]
line wrap: on
line diff
--- a/src/macosx/classes/com/apple/laf/AquaComboBoxUI.java	Wed Nov 19 12:45:04 2014 +0400
+++ b/src/macosx/classes/com/apple/laf/AquaComboBoxUI.java	Wed Nov 19 18:57:39 2014 +0400
@@ -486,10 +486,15 @@
 
     // This is somewhat messy.  The difference here from BasicComboBoxUI.EnterAction is that
     // arrow up or down does not automatically select the
-    private static final Action triggerSelectionAction = new AbstractAction() {
+    private final Action triggerSelectionAction = new AbstractAction() {
         public void actionPerformed(final ActionEvent e) {
             triggerSelectionEvent((JComboBox)e.getSource(), e);
         }
+
+        @Override
+        public boolean isEnabled() {
+            return comboBox.isPopupVisible() && super.isEnabled();
+        }
     };
 
     private static final Action toggleSelectionAction = new AbstractAction() {
--- a/test/javax/swing/JComboBox/ConsumedEscTest/ConsumedEscTest.java	Wed Nov 19 12:45:04 2014 +0400
+++ /dev/null	Thu Jan 01 00:00:00 1970 +0000
@@ -1,88 +0,0 @@
-/*
- * Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved.
- * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
- *
- * This code is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 only, as
- * published by the Free Software Foundation.
- *
- * This code is distributed in the hope that it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
- * version 2 for more details (a copy is included in the LICENSE file that
- * accompanied this code).
- *
- * You should have received a copy of the GNU General Public License version
- * 2 along with this work; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
- *
- * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
- * or visit www.oracle.com if you need additional information or have any
- * questions.
- */
-
-import javax.swing.*;
-import java.awt.event.ActionEvent;
-import java.awt.event.KeyEvent;
-import java.awt.Robot;
-import java.awt.Toolkit;
-import sun.awt.SunToolkit;
-
-/*
-  @test
-  @bug 8031485
-  @summary Combo box consuming escape and enter key events
-  @author Petr Pchelko
-  @run main ConsumedEscTest
-*/
-public class ConsumedEscTest {
-    private static volatile JFrame frame;
-    private static volatile boolean passed = false;
-
-    public static void main(String... args) throws Exception {
-        try {
-            SwingUtilities.invokeAndWait(() -> {
-                frame = new JFrame();
-                JComboBox<String> combo = new JComboBox<>(new String[]{"one", "two", "three"});
-                JPanel panel = new JPanel();
-                panel.add(combo);
-                combo.requestFocusInWindow();
-                frame.setBounds(100, 150, 300, 100);
-                addAction(panel);
-                frame.add(panel);
-                frame.setVisible(true);
-            });
-
-            Robot robot = new Robot();
-            robot.waitForIdle();
-            ((SunToolkit)Toolkit.getDefaultToolkit()).realSync();
-            robot.keyPress(KeyEvent.VK_ESCAPE);
-            robot.waitForIdle();
-            ((SunToolkit)Toolkit.getDefaultToolkit()).realSync();
-            robot.keyRelease(KeyEvent.VK_ESCAPE);
-            robot.waitForIdle();
-            ((SunToolkit)Toolkit.getDefaultToolkit()).realSync();
-            if (!passed) {
-                throw new RuntimeException("FAILED: ESC was consumed by combo box");
-            }
-        } finally {
-            if (frame != null) {
-                frame.dispose();
-            }
-        }
-    }
-
-    private static void addAction(JComponent comp) {
-        KeyStroke k = KeyStroke.getKeyStroke(KeyEvent.VK_ESCAPE, 0);
-        Object actionKey = "cancel";
-        comp.getInputMap(JComponent.WHEN_ANCESTOR_OF_FOCUSED_COMPONENT).put(k, actionKey);
-        Action cancelAction = new AbstractAction() {
-            @Override
-            public void actionPerformed(ActionEvent ev) {
-                passed = true;
-            }
-        };
-        comp.getActionMap().put(actionKey, cancelAction);
-    }
-
-}
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/test/javax/swing/JComboBox/ConsumedKeyTest/ConsumedKeyTest.java	Wed Nov 19 18:57:39 2014 +0400
@@ -0,0 +1,94 @@
+/*
+ * Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+import javax.swing.*;
+import java.awt.event.ActionEvent;
+import java.awt.event.KeyEvent;
+import java.awt.Toolkit;
+import java.awt.Robot;
+import sun.awt.SunToolkit;
+
+/*
+  @test
+  @bug 8031485 8058193
+  @summary Combo box consuming escape and enter key events
+  @author Petr Pchelko
+  @run main ConsumedKeyTest
+*/
+public class ConsumedKeyTest {
+    private static volatile JFrame frame;
+    private static volatile boolean passed;
+
+    public static void main(String... args) throws Exception {
+        test(KeyEvent.VK_ESCAPE);
+        test(KeyEvent.VK_ENTER);
+    }
+
+    private static void test(final int key) throws Exception {
+        passed = false;
+        try {
+            SwingUtilities.invokeAndWait(() -> {
+                frame = new JFrame();
+                JComboBox<String> combo = new JComboBox<>(new String[]{"one", "two", "three"});
+                JPanel panel = new JPanel();
+                panel.add(combo);
+                combo.requestFocusInWindow();
+                frame.setBounds(100, 150, 300, 100);
+                addAction(panel, key);
+                frame.add(panel);
+                frame.setVisible(true);
+            });
+
+            Robot robot = new Robot();
+            robot.waitForIdle();
+            ((SunToolkit)Toolkit.getDefaultToolkit()).realSync();
+            robot.keyPress(key);
+            robot.waitForIdle();
+            ((SunToolkit)Toolkit.getDefaultToolkit()).realSync();
+            robot.keyRelease(key);
+            robot.waitForIdle();
+            ((SunToolkit)Toolkit.getDefaultToolkit()).realSync();
+            if (!passed) {
+                throw new RuntimeException("FAILED: " + KeyEvent.getKeyText(key) + " was consumed by combo box");
+            }
+        } finally {
+            if (frame != null) {
+                frame.dispose();
+            }
+        }
+
+    }
+
+    private static void addAction(JComponent comp, final int key) {
+        KeyStroke k = KeyStroke.getKeyStroke(key, 0);
+        Object actionKey = "cancel";
+        comp.getInputMap(JComponent.WHEN_ANCESTOR_OF_FOCUSED_COMPONENT).put(k, actionKey);
+        Action cancelAction = new AbstractAction() {
+            @Override
+            public void actionPerformed(ActionEvent ev) {
+                passed = true;
+            }
+        };
+        comp.getActionMap().put(actionKey, cancelAction);
+    }
+}