OpenJDK / lambda / lambda / jdk
changeset 3982:71e769dc8cf6
6985329: 9 classes in swing.plaf contains words inappropriate for public spec - about some compiler bug
Reviewed-by: rupashka
| author | alexp |
|---|---|
| date | Fri, 15 Apr 2011 21:26:09 +0400 |
| parents | 1e2366f02b50 |
| children | d353dcff4f14 |
| files | src/share/classes/javax/swing/plaf/basic/BasicColorChooserUI.java src/share/classes/javax/swing/plaf/basic/BasicDesktopIconUI.java src/share/classes/javax/swing/plaf/basic/BasicListUI.java src/share/classes/javax/swing/plaf/basic/BasicOptionPaneUI.java src/share/classes/javax/swing/plaf/basic/BasicProgressBarUI.java src/share/classes/javax/swing/plaf/basic/BasicTableHeaderUI.java src/share/classes/javax/swing/plaf/basic/BasicTableUI.java src/share/classes/javax/swing/plaf/metal/MetalComboBoxUI.java src/share/classes/javax/swing/plaf/metal/MetalTabbedPaneUI.java |
| diffstat | 9 files changed, 14 insertions(+), 29 deletions(-) [+] |
line wrap: on
line diff
--- a/src/share/classes/javax/swing/plaf/basic/BasicColorChooserUI.java Fri Apr 15 20:54:13 2011 +0400 +++ b/src/share/classes/javax/swing/plaf/basic/BasicColorChooserUI.java Fri Apr 15 21:26:09 2011 +0400 @@ -335,9 +335,8 @@ } /** - * This inner class is marked "public" due to a compiler bug. * This class should be treated as a "protected" inner class. - * Instantiate it only within subclasses of <Foo>. + * Instantiate it only within subclasses of {@code BasicColorChooserUI}. */ public class PropertyHandler implements PropertyChangeListener { public void propertyChange(PropertyChangeEvent e) {
--- a/src/share/classes/javax/swing/plaf/basic/BasicDesktopIconUI.java Fri Apr 15 20:54:13 2011 +0400 +++ b/src/share/classes/javax/swing/plaf/basic/BasicDesktopIconUI.java Fri Apr 15 21:26:09 2011 +0400 @@ -186,9 +186,8 @@ /** * Listens for mouse movements and acts on them. * - * This inner class is marked "public" due to a compiler bug. * This class should be treated as a "protected" inner class. - * Instantiate it only within subclasses of <Foo>. + * Instantiate it only within subclasses of {@code BasicDesktopIconUI}. */ public class MouseInputHandler extends MouseInputAdapter {
--- a/src/share/classes/javax/swing/plaf/basic/BasicListUI.java Fri Apr 15 20:54:13 2011 +0400 +++ b/src/share/classes/javax/swing/plaf/basic/BasicListUI.java Fri Apr 15 21:26:09 2011 +0400 @@ -1555,9 +1555,8 @@ } /** - * This inner class is marked "public" due to a compiler bug. * This class should be treated as a "protected" inner class. - * Instantiate it only within subclasses of BasicTableUI. + * Instantiate it only within subclasses of {@code BasicListUI}. */ public class FocusHandler implements FocusListener {
--- a/src/share/classes/javax/swing/plaf/basic/BasicOptionPaneUI.java Fri Apr 15 20:54:13 2011 +0400 +++ b/src/share/classes/javax/swing/plaf/basic/BasicOptionPaneUI.java Fri Apr 15 21:26:09 2011 +0400 @@ -911,9 +911,8 @@ * right. If <code>syncAllWidths</code> is true, the widths of each * component will be set to the largest preferred size width. * - * This inner class is marked "public" due to a compiler bug. * This class should be treated as a "protected" inner class. - * Instantiate it only within subclasses of BasicOptionPaneUI. + * Instantiate it only within subclasses of {@code BasicOptionPaneUI}. */ public static class ButtonAreaLayout implements LayoutManager { protected boolean syncAllWidths; @@ -1115,9 +1114,8 @@ /** - * This inner class is marked "public" due to a compiler bug. * This class should be treated as a "protected" inner class. - * Instantiate it only within subclasses of BasicOptionPaneUI. + * Instantiate it only within subclasses of {@code BasicOptionPaneUI}. */ public class PropertyChangeHandler implements PropertyChangeListener { /** @@ -1161,9 +1159,8 @@ } /** - * This inner class is marked "public" due to a compiler bug. * This class should be treated as a "protected" inner class. - * Instantiate it only within subclasses of BasicOptionPaneUI. + * Instantiate it only within subclasses of {@code BasicOptionPaneUI}. */ public class ButtonActionListener implements ActionListener { protected int buttonIndex;
--- a/src/share/classes/javax/swing/plaf/basic/BasicProgressBarUI.java Fri Apr 15 20:54:13 2011 +0400 +++ b/src/share/classes/javax/swing/plaf/basic/BasicProgressBarUI.java Fri Apr 15 21:26:09 2011 +0400 @@ -1211,9 +1211,8 @@ /** - * This inner class is marked "public" due to a compiler bug. * This class should be treated as a "protected" inner class. - * Instantiate it only within subclasses of BasicProgressBarUI. + * Instantiate it only within subclasses of {@code BasicProgressBarUI}. */ public class ChangeHandler implements ChangeListener { // NOTE: This class exists only for backward compatability. All
--- a/src/share/classes/javax/swing/plaf/basic/BasicTableHeaderUI.java Fri Apr 15 20:54:13 2011 +0400 +++ b/src/share/classes/javax/swing/plaf/basic/BasicTableHeaderUI.java Fri Apr 15 21:26:09 2011 +0400 @@ -88,9 +88,8 @@ }; /** - * This inner class is marked "public" due to a compiler bug. * This class should be treated as a "protected" inner class. - * Instantiate it only within subclasses of BasicTableUI. + * Instantiate it only within subclasses of {@code BasicTableHeaderUI}. */ public class MouseInputHandler implements MouseInputListener {
--- a/src/share/classes/javax/swing/plaf/basic/BasicTableUI.java Fri Apr 15 20:54:13 2011 +0400 +++ b/src/share/classes/javax/swing/plaf/basic/BasicTableUI.java Fri Apr 15 21:26:09 2011 +0400 @@ -730,9 +730,8 @@ // /** - * This inner class is marked "public" due to a compiler bug. * This class should be treated as a "protected" inner class. - * Instantiate it only within subclasses of BasicTableUI. + * Instantiate it only within subclasses of {@code BasicTableUI}. * <p>As of Java 2 platform v1.3 this class is no longer used. * Instead <code>JTable</code> * overrides <code>processKeyBinding</code> to dispatch the event to @@ -761,9 +760,8 @@ // /** - * This inner class is marked "public" due to a compiler bug. * This class should be treated as a "protected" inner class. - * Instantiate it only within subclasses of BasicTableUI. + * Instantiate it only within subclasses of {@code BasicTableUI}. */ public class FocusHandler implements FocusListener { // NOTE: This class exists only for backward compatability. All @@ -784,7 +782,6 @@ // /** - * This inner class is marked "public" due to a compiler bug. * This class should be treated as a "protected" inner class. * Instantiate it only within subclasses of BasicTableUI. */
--- a/src/share/classes/javax/swing/plaf/metal/MetalComboBoxUI.java Fri Apr 15 20:54:13 2011 +0400 +++ b/src/share/classes/javax/swing/plaf/metal/MetalComboBoxUI.java Fri Apr 15 21:26:09 2011 +0400 @@ -199,9 +199,8 @@ } /** - * This inner class is marked "public" due to a compiler bug. * This class should be treated as a "protected" inner class. - * Instantiate it only within subclasses of <FooUI>. + * Instantiate it only within subclasses of {@code MetalComboBoxUI}. */ public class MetalPropertyChangeListener extends BasicComboBoxUI.PropertyChangeHandler { public void propertyChange(PropertyChangeEvent e) { @@ -244,9 +243,8 @@ } /** - * This inner class is marked "public" due to a compiler bug. * This class should be treated as a "protected" inner class. - * Instantiate it only within subclasses of <FooUI>. + * Instantiate it only within subclasses of {@code MetalComboBoxUI}. */ public class MetalComboBoxLayoutManager extends BasicComboBoxUI.ComboBoxLayoutManager { public void layoutContainer( Container parent ) { @@ -356,9 +354,8 @@ } /** - * This inner class is marked "public" due to a compiler bug. * This class should be treated as a "protected" inner class. - * Instantiate it only within subclasses of <FooUI>. + * Instantiate it only within subclasses of {@code MetalComboBoxUI}. * * This class is now obsolete and doesn't do anything and * is only included for backwards API compatibility. Do not call or
--- a/src/share/classes/javax/swing/plaf/metal/MetalTabbedPaneUI.java Fri Apr 15 20:54:13 2011 +0400 +++ b/src/share/classes/javax/swing/plaf/metal/MetalTabbedPaneUI.java Fri Apr 15 21:26:09 2011 +0400 @@ -1196,9 +1196,8 @@ } /** - * This inner class is marked "public" due to a compiler bug. * This class should be treated as a "protected" inner class. - * Instantiate it only within subclasses of MetalTabbedPaneUI. + * Instantiate it only within subclasses of {@code MetalTabbedPaneUI}. */ public class TabbedPaneLayout extends BasicTabbedPaneUI.TabbedPaneLayout {