changeset 480:481644d9a6c5

meth: tweak ShowHiddenFrames behavior to disclose BCIs as well
author jrose
date Sat, 14 Jul 2012 17:57:27 -0700
parents f128e52774bf
children a211c1a525fd
files meth-lazy-7023639.review.patch series
diffstat 2 files changed, 25 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/meth-lazy-7023639.review.patch	Sat Jul 14 17:57:27 2012 -0700
@@ -0,0 +1,24 @@
+# HG changeset patch
+# Parent bb58a0b59bb5a35eb987814dfb51044033b9e41f
+diff --git a/src/share/vm/classfile/javaClasses.cpp b/src/share/vm/classfile/javaClasses.cpp
+--- a/src/share/vm/classfile/javaClasses.cpp
++++ b/src/share/vm/classfile/javaClasses.cpp
+@@ -1738,6 +1738,8 @@
+   java_lang_StackTraceElement::set_methodName(element(), methodname);
+   // Fill in source file name
+   Symbol* source = instanceKlass::cast(method->method_holder())->source_file_name();
++  if (ShowHiddenFrames && source == NULL)
++    source = vmSymbols::unknown_class_name();
+   oop filename = StringTable::intern(source, CHECK_0);
+   java_lang_StackTraceElement::set_fileName(element(), filename);
+   // File in source line number
+@@ -1750,6 +1752,9 @@
+   } else {
+     // Returns -1 if no LineNumberTable, and otherwise actual line number
+     line_number = method->line_number_from_bci(bci);
++    if (line_number == -1 && ShowHiddenFrames) {
++      line_number = bci + 1000000;
++    }
+   }
+   java_lang_StackTraceElement::set_lineNumber(element(), line_number);
+ 
--- a/series	Sat Jul 14 17:56:17 2012 -0700
+++ b/series	Sat Jul 14 17:57:27 2012 -0700
@@ -2,6 +2,7 @@
 
 # review pending before push to hotspot-comp:
 meth-lazy-7023639.patch         #-/meth #+ed21db7b3fda
+meth-lazy-7023639.review.patch  #-/meth #+ed21db7b3fda
 
 # non-pushed files are under review or development, or merely experimental:
 meth.patch                      #-/meth #+ed21db7b3fda