changeset 1408:b06e3fb7dd1a

Automated merge with ssh://jfxsrc.us.oracle.com//javafx/2.2/scrum/controls/jfx/rt
author jgiles
date Wed, 04 Jul 2012 07:37:04 +1200
parents 9bcfd0822e48 ea0e80ad3933
children 53c9087d14fb 330911490952
files
diffstat 21 files changed, 103 insertions(+), 78 deletions(-) [+]
line wrap: on
line diff
--- a/javafx-ui-common/src/javafx/scene/canvas/GraphicsContext.java	Tue Jul 03 14:35:20 2012 -0400
+++ b/javafx-ui-common/src/javafx/scene/canvas/GraphicsContext.java	Wed Jul 04 07:37:04 2012 +1200
@@ -518,12 +518,7 @@
      * Sets the current transform ignoring any 3D transform by grabbing the 2x3
      * of the matrix. 3D transforms are not supported in a 2D GraphicsContext.
      * 
-     * @param mxx 
-     * @param myx
-     * @param mxy 
-     * @param myy 
-     * @param mxt
-     * @param myt  
+     * @param xform
      */
     public void setTransform(Affine xform) {
         curState.transform.setTransform(xform.getMxx(), xform.getMyx(),
@@ -655,7 +650,7 @@
     /**
      * gets the current state's stroke.
      * 
-     * @param p The Paint to be used as the stroke Paint.
+     * @return The Paint to be used as the stroke Paint.
      */
     public Paint getStroke() {
         return curState.stroke;
@@ -766,7 +761,7 @@
     /**
      * Gets the current miter limit attribute.
      * 
-     * @param miter limit value between 0 and positive infinity with 
+     * @return limit value between 0 and positive infinity with 
      * any other value being ignored and leaving the value unchanged.
      */
     public double getMiterLimit() {
--- a/javafx-ui-common/src/javafx/scene/image/PixelFormat.java	Tue Jul 03 14:35:20 2012 -0400
+++ b/javafx-ui-common/src/javafx/scene/image/PixelFormat.java	Wed Jul 04 07:37:04 2012 +1200
@@ -155,10 +155,10 @@
      * The buffer should be positioned to the start of the pixel data such
      * that {@code buf.get(0)} would return the pixel information for the
      * pixel at coordinates {@code (0, 0)}.
-     * The {@scanlineStride} parameter defines the distance from the pixel
+     * The {@code scanlineStride} parameter defines the distance from the pixel
      * data at the start of one row to the pixel data at the start of the
      * immediately following row at the next higher Y coordinate.  Usually,
-     * {@scanlineStride} is the same as the width of the image multiplied
+     * {@code scanlineStride} is the same as the width of the image multiplied
      * by the number of data elements per pixel (1 for the case of the
      * integer and indexed formats, or 3 or 4 in the case of the byte
      * formats), but some images may have further padding between rows for
--- a/javafx-ui-common/src/javafx/scene/image/WritablePixelFormat.java	Tue Jul 03 14:35:20 2012 -0400
+++ b/javafx-ui-common/src/javafx/scene/image/WritablePixelFormat.java	Wed Jul 04 07:37:04 2012 +1200
@@ -55,10 +55,10 @@
      * The buffer should be positioned to the start of the pixel data such
      * that {@code buf.get(0)} would return the pixel information for the
      * pixel at coordinates {@code (0, 0)}.
-     * The {@scanlineStride} parameter defines the distance from the pixel
+     * The {@code scanlineStride} parameter defines the distance from the pixel
      * data at the start of one row to the pixel data at the start of the
      * immediately following row at the next higher Y coordinate.  Usually,
-     * {@scanlineStride} is the same as the width of the image multiplied
+     * {@code scanlineStride} is the same as the width of the image multiplied
      * by the number of data elements per pixel (1 for the case of the
      * integer and indexed formats, or 3 or 4 in the case of the byte
      * formats), but some images may have further padding between rows for
--- a/javafx-ui-common/src/javafx/scene/input/InputMethodEvent.java	Tue Jul 03 14:35:20 2012 -0400
+++ b/javafx-ui-common/src/javafx/scene/input/InputMethodEvent.java	Wed Jul 04 07:37:04 2012 +1200
@@ -55,8 +55,8 @@
  * text change in a {@link Node}.
  * <p>
  * This event is delivered to the {@link Node} object that extends 
- * {@link javafx.scene.control.TextInput}, when the text under composition (composed text) is
- * generated/changed/removed, the input method commits
+ * {@link javafx.scene.control.TextInputControl}, when the text under composition 
+ * (composed text) is generated/changed/removed, the input method commits
  * the result text, or the input method caret position changes.
  * <p>
  * On receiving this event, the application is supposed to display
--- a/javafx-ui-common/src/javafx/scene/input/MouseEvent.java	Tue Jul 03 14:35:20 2012 -0400
+++ b/javafx-ui-common/src/javafx/scene/input/MouseEvent.java	Wed Jul 04 07:37:04 2012 +1200
@@ -758,8 +758,8 @@
 
     /**
      * {@code true} if primary button (button 1, usually the left) is currently
-     * pressed. Note that this is different from the {@link button} variable in
-     * that the {@code button} variable indicates which button press was
+     * pressed. Note that this is different from the {@link #getButton() button}
+     * variable in that the {@code button} variable indicates which button press was
      * responsible for this event while this variable indicates whether the
      * primary button is depressed.
      */
@@ -781,8 +781,8 @@
 
     /**
      * {@code true} if secondary button (button 3, usually the right) is currently
-     * pressed. Note that this is different from the {@link button} variable in
-     * that the {@code button} variable indicates which button press was
+     * pressed. Note that this is different from the {@link #getButton() button} 
+     * variable in that the {@code button} variable indicates which button press was
      * responsible for this event while this variable indicates whether the
      * primary button is depressed.
      */
@@ -804,7 +804,7 @@
 
     /**
      * {@code true} if middle button (button 2) is currently pressed.
-     * Note that this is different from the {@link button} variable in
+     * Note that this is different from the {@link #getButton() button} variable in
      * that the {@code button} variable indicates which button press was
      * responsible for this event while this variable indicates whether the
      * middle button is depressed.
--- a/javafx-ui-common/src/javafx/scene/paint/ImagePattern.java	Tue Jul 03 14:35:20 2012 -0400
+++ b/javafx-ui-common/src/javafx/scene/paint/ImagePattern.java	Wed Jul 04 07:37:04 2012 +1200
@@ -144,7 +144,7 @@
     /**
      * Gets the x origin of the anchor rectangle.
      *
-     * @default 0.0
+     * @defaultValue 0.0
      * @return The x origin of the anchor rectangle.
      */
     public final double getX() {
@@ -156,7 +156,7 @@
     /**
      * Gets the y origin of the anchor rectangle.
      *
-     * @default 0.0
+     * @defaultValue 0.0
      * @return The y origin of the anchor rectangle.
      */
     public final double getY() {
@@ -169,7 +169,7 @@
     /**
      * Gets the width of the anchor rectangle.
      *
-     * @default 1.0
+     * @defaultValue 1.0
      * @return The width of the anchor rectangle.
      */
     public final double getWidth() {
@@ -182,7 +182,7 @@
     /**
      * Gets the height of the anchor rectangle.
      *
-     * @default 1.0
+     * @defaultValue 1.0
      * @return The height of the anchor rectangle.
      */
     public final double getHeight() {
--- a/javafx-ui-common/src/javafx/stage/Stage.java	Tue Jul 03 14:35:20 2012 -0400
+++ b/javafx-ui-common/src/javafx/stage/Stage.java	Wed Jul 04 07:37:04 2012 +1200
@@ -223,7 +223,7 @@
     }
     
     /**
-     * @InheritDoc
+     * @inheritDoc
      */
     @Override public final void show() {
         super.show();
--- a/javafx-ui-controls/src/javafx/scene/control/CheckBoxTreeItem.java	Tue Jul 03 14:35:20 2012 -0400
+++ b/javafx-ui-controls/src/javafx/scene/control/CheckBoxTreeItem.java	Wed Jul 04 07:37:04 2012 +1200
@@ -38,16 +38,24 @@
 /**
  * TreeItem subclass that adds support for being in selected, unselected, and
  * indeterminate states. This is useful when used in conjunction with a TreeView
- * which has a {@link CheckBoxCellFactory} installed.
+ * which has a {@link CheckBoxTreeCell} installed.
  * 
  * <p>A CheckBoxTreeItem can be {@link #independentProperty() independent} or 
  * dependent. By default, CheckBoxTreeItem instances are dependent, which means 
  * that any changes to the selection state of a TreeItem will have an impact on 
- * parent and children CheckBoxTreeItem instances. 
+ * parent and children CheckBoxTreeItem instances. If a CheckBoxTreeItem is
+ * set to be independent, this means that any changes to that CheckBoxTreeItem
+ * will not directly impact the state of parent and children CheckBoxTreeItem
+ * instances.
+ * 
+ * <p>The {@link #indeterminateProperty() indeterminate} property is used to
+ * represent the same concept as that in {@link CheckBox#indeterminateProperty()},
+ * namely, that the CheckBox is neither selected or unselected. This is commonly
+ * used inside a TreeView when some, but not all, of a branches children are
+ * selected.
  * 
  * <p>A simple example of using the CheckBoxTreeItem class, in conjunction with 
- * {@link CheckBoxCellFactory} or {@link CheckBoxTreeCell} classes is shown 
- * below:
+ * {@link CheckBoxTreeCell} is shown below:
  * 
  * <pre><code>
  * // create the tree model
@@ -66,7 +74,7 @@
  * treeView.setRoot(gilesFamily);
  *       
  * // set the cell factory
- * treeView.setCellFactory(CheckBoxCellFactory.&lt;String&gt;forTreeView());</code></pre>
+ * treeView.setCellFactory(CheckBoxTreeCell.&lt;String&gt;forTreeView());</code></pre>
  *
  * @see CheckBoxTreeCell
  * @see TreeItem
--- a/javafx-ui-controls/src/javafx/scene/control/Pagination.java	Tue Jul 03 14:35:20 2012 -0400
+++ b/javafx-ui-controls/src/javafx/scene/control/Pagination.java	Wed Jul 04 07:37:04 2012 +1200
@@ -67,7 +67,7 @@
  * <h3>Styling the page indicators</h3>
  * <p>
  * The control can be customized to display numeric page indicators or bullet style indicators by
- * setting the style class {@link STYLE_CLASS_BULLET}.  The
+ * setting the style class {@link #STYLE_CLASS_BULLET}.  The
  * {@link #maxPageIndicatorCountProperty() maxPageIndicatorCountProperty} can be used to change
  * the maximum number of page indicators.  The property value can also be changed
  * via CSS using -fx-max-page-indicator-count.
@@ -154,7 +154,7 @@
     }
 
     /**
-     * Constructs a Pagination control with an {@link INDETERMINATE} page count
+     * Constructs a Pagination control with an {@link #INDETERMINATE} page count
      * and a page index equal to zero.
      */
     public Pagination() {
@@ -250,10 +250,10 @@
 
     /**
      * The number of pages for this pagination control.  This
-     * value must be greater than or equal to 1.  {@link INDETERMINATE}
+     * value must be greater than or equal to 1. {@link #INDETERMINATE}
      * should be used as the page count if the total number of pages is unknown.
      *
-     * The default is an {@link INDETERMINATE} number of pages.
+     * The default is an {@link #INDETERMINATE} number of pages.
      */
     public final IntegerProperty pageCountProperty() { return pageCount; }
 
--- a/javafx-ui-controls/src/javafx/scene/control/SplitPane.java	Tue Jul 03 14:35:20 2012 -0400
+++ b/javafx-ui-controls/src/javafx/scene/control/SplitPane.java	Wed Jul 04 07:37:04 2012 +1200
@@ -142,7 +142,7 @@
     /**
      * Return true if the node is resizable when the parent container is resized false otherwise.
      * @param node A node in the SplitPane.
-     * @default true
+     * @defaultValue true
      * @return true if the node is resizable false otherwise.
      */
     public static Boolean isResizableWithParent(Node node) {
--- a/javafx-ui-controls/src/javafx/scene/control/Tab.java	Tue Jul 03 14:35:20 2012 -0400
+++ b/javafx-ui-controls/src/javafx/scene/control/Tab.java	Wed Jul 04 07:37:04 2012 +1200
@@ -514,7 +514,7 @@
     /**
      * Sets the disabled state of this tab. A disable tab is no longer interactive
      * or traversable, but the contents remain interactive.  A disable tab 
-     * can be selected using {@link TabPane.getSelectionModel()}.
+     * can be selected using {@link TabPane#getSelectionModel()}.
      * 
      * @defaultValue false
      */    
--- a/javafx-ui-controls/src/javafx/scene/control/Tooltip.java	Tue Jul 03 14:35:20 2012 -0400
+++ b/javafx-ui-controls/src/javafx/scene/control/Tooltip.java	Wed Jul 04 07:37:04 2012 +1200
@@ -194,8 +194,9 @@
     }
     /**
      * Specifies the behavior for lines of text <em>when text is multiline</em>.
-     * Unlike {@link #contentDisplay} which affects the graphic and text, this setting
-     * only affects multiple lines of text relative to the text bounds.
+     * Unlike {@link #contentDisplayProperty() contentDisplay} which affects the 
+     * graphic and text, this setting only affects multiple lines of text 
+     * relative to the text bounds.
      */
     public final ObjectProperty<TextAlignment> textAlignmentProperty() {
         return ((Tooltip.CSSBridge)bridge).textAlignmentProperty();
@@ -245,7 +246,8 @@
 
     /**
      * An optional icon for the Tooltip. This can be positioned relative to the
-     * text by using the {@link #contentDisplay} property.
+     * text by using the {@link #contentDisplayProperty() content display} 
+     * property.
      * The node specified for this variable cannot appear elsewhere in the
      * scene graph, otherwise the {@code IllegalArgumentException} is thrown.
      * See the class description of {@link javafx.scene.Node Node} for more detail.
--- a/javafx-ui-controls/src/javafx/scene/control/cell/CellUtils.java	Tue Jul 03 14:35:20 2012 -0400
+++ b/javafx-ui-controls/src/javafx/scene/control/cell/CellUtils.java	Wed Jul 04 07:37:04 2012 +1200
@@ -96,7 +96,7 @@
             converter.toString(cell.getItem());
     }
     
-    
+
     
     /***************************************************************************
      *                                                                         *
@@ -191,6 +191,12 @@
         textField.setOnKeyReleased(new EventHandler<KeyEvent>() {
             @Override public void handle(KeyEvent t) {
                 if (t.getCode() == KeyCode.ENTER) {
+                    if (converter == null) {
+                        throw new IllegalStateException(
+                            "Attempting to convert text input into Object, but provided "
+                                + "StringConverter is null. Be sure to set a StringConverter "
+                                + "in your cell factory.");
+                    }
                     cell.commitEdit(converter.fromString(textField.getText()));
                 } else if (t.getCode() == KeyCode.ESCAPE) {
                     cell.cancelEdit();
--- a/javafx-ui-controls/src/javafx/scene/control/cell/CheckBoxListCell.java	Tue Jul 03 14:35:20 2012 -0400
+++ b/javafx-ui-controls/src/javafx/scene/control/cell/CheckBoxListCell.java	Wed Jul 04 07:37:04 2012 +1200
@@ -53,7 +53,6 @@
  * interactions, and the CheckBox will reflect the state of the 
  * ObservableValue<Boolean>, if it changes externally).
  * 
- * @see CheckBoxCellFactory
  * @see CheckBox
  * @see ListCell
  * @param <T> The type of the elements contained within the ListView.
--- a/javafx-ui-controls/src/javafx/scene/control/cell/CheckBoxTableCell.java	Tue Jul 03 14:35:20 2012 -0400
+++ b/javafx-ui-controls/src/javafx/scene/control/cell/CheckBoxTableCell.java	Wed Jul 04 07:37:04 2012 +1200
@@ -134,8 +134,9 @@
      *      the TableCell beside the {@link CheckBox}. By default a label is not 
      *      shown, but by setting this to true the item in the cell will also 
      *      have toString() called on it. If this is not the desired behavior, 
-     *      consider using {@link #forTableColumn(Callback, Callback)}, which 
-     *      allows for you to provide a callback that specifies the label for a 
+     *      consider using 
+     *      {@link #forTableColumn(javafx.util.Callback, javafx.util.StringConverter) }, 
+     *      which allows for you to provide a callback that specifies the label for a 
      *      given row item.
      * @return A {@link Callback} that will return a {@link TableCell} that is 
      *      able to work on the type of element contained within the TableColumn.
--- a/javafx-ui-controls/src/javafx/scene/control/cell/ChoiceBoxTableCell.java	Tue Jul 03 14:35:20 2012 -0400
+++ b/javafx-ui-controls/src/javafx/scene/control/cell/ChoiceBoxTableCell.java	Wed Jul 04 07:37:04 2012 +1200
@@ -29,6 +29,7 @@
 import javafx.beans.property.SimpleObjectProperty;
 import javafx.collections.FXCollections;
 import javafx.collections.ObservableList;
+import javafx.event.EventHandler;
 import javafx.scene.control.ChoiceBox;
 import javafx.scene.control.Label;
 import javafx.scene.control.TableCell;
@@ -70,9 +71,9 @@
      *      type as the TableColumn. Note that it is up to the developer to set 
      *      {@link EventHandler event handlers} to listen to edit events in the 
      *      TableColumn, and react accordingly. Methods of interest include 
-     *      {@link TableColumn#setOnEditStart(EventHandler) setOnEditStart},
+     *      {@link TableColumn#setOnEditStart(javafx.event.EventHandler) setOnEditStart},
      *      {@link TableColumn#setOnEditCommit(javafx.event.EventHandler) setOnEditCommit}, 
-     *      and {@link TableColumn#setOnEditCancel(EventHandler) setOnEditCancel}.
+     *      and {@link TableColumn#setOnEditCancel(javafx.event.EventHandler) setOnEditCancel}.
      * @return A {@link Callback} that will return a TableCell that is able to 
      *      work on the type of element contained within the TableColumn.
      */
@@ -94,9 +95,9 @@
      *      type as the TableColumn. Note that it is up to the developer to set 
      *      {@link EventHandler event handlers} to listen to edit events in the 
      *      TableColumn, and react accordingly. Methods of interest include 
-     *      {@link TableColumn#setOnEditStart(EventHandler) setOnEditStart},
+     *      {@link TableColumn#setOnEditStart(javafx.event.EventHandler) setOnEditStart},
      *      {@link TableColumn#setOnEditCommit(javafx.event.EventHandler) setOnEditCommit}, 
-     *      and {@link TableColumn#setOnEditCancel(EventHandler) setOnEditCancel}.
+     *      and {@link TableColumn#setOnEditCancel(javafx.event.EventHandler) setOnEditCancel}.
      * @return A {@link Callback} that will return a TableCell that is able to 
      *      work on the type of element contained within the TableColumn.
      */
@@ -118,9 +119,9 @@
      *      type as the TableColumn. Note that it is up to the developer to set 
      *      {@link EventHandler event handlers} to listen to edit events in the 
      *      TableColumn, and react accordingly. Methods of interest include 
-     *      {@link TableColumn#setOnEditStart(EventHandler) setOnEditStart},
+     *      {@link TableColumn#setOnEditStart(javafx.event.EventHandler) setOnEditStart},
      *      {@link TableColumn#setOnEditCommit(javafx.event.EventHandler) setOnEditCommit}, 
-     *      and {@link TableColumn#setOnEditCancel(EventHandler) setOnEditCancel}.
+     *      and {@link TableColumn#setOnEditCancel(javafx.event.EventHandler) setOnEditCancel}.
      * @return A {@link Callback} that will return a TableCell that is able to 
      *      work on the type of element contained within the TableColumn.
      */
@@ -143,9 +144,9 @@
      *      type as the TableColumn. Note that it is up to the developer to set 
      *      {@link EventHandler event handlers} to listen to edit events in the 
      *      TableColumn, and react accordingly. Methods of interest include 
-     *      {@link TableColumn#setOnEditStart(EventHandler) setOnEditStart},
+     *      {@link TableColumn#setOnEditStart(javafx.event.EventHandler) setOnEditStart},
      *      {@link TableColumn#setOnEditCommit(javafx.event.EventHandler) setOnEditCommit}, 
-     *      and {@link TableColumn#setOnEditCancel(EventHandler) setOnEditCancel}.
+     *      and {@link TableColumn#setOnEditCancel(javafx.event.EventHandler) setOnEditCancel}.
      * @return A {@link Callback} that will return a TableCell that is able to 
      *      work on the type of element contained within the TableColumn.
      */
--- a/javafx-ui-controls/src/javafx/scene/control/cell/ComboBoxTableCell.java	Tue Jul 03 14:35:20 2012 -0400
+++ b/javafx-ui-controls/src/javafx/scene/control/cell/ComboBoxTableCell.java	Wed Jul 04 07:37:04 2012 +1200
@@ -31,6 +31,7 @@
 import javafx.beans.property.SimpleObjectProperty;
 import javafx.collections.FXCollections;
 import javafx.collections.ObservableList;
+import javafx.event.EventHandler;
 import javafx.scene.control.ComboBox;
 import javafx.scene.control.Label;
 import javafx.scene.control.TableCell;
@@ -72,9 +73,9 @@
      *      type as the TableColumn. Note that it is up to the developer to set 
      *      {@link EventHandler event handlers} to listen to edit events in the 
      *      TableColumn, and react accordingly. Methods of interest include 
-     *      {@link TableColumn#setOnEditStart(EventHandler) setOnEditStart},
+     *      {@link TableColumn#setOnEditStart(javafx.event.EventHandler) setOnEditStart},
      *      {@link TableColumn#setOnEditCommit(javafx.event.EventHandler) setOnEditCommit}, 
-     *      and {@link TableColumn#setOnEditCancel(EventHandler) setOnEditCancel}.
+     *      and {@link TableColumn#setOnEditCancel(javafx.event.EventHandler) setOnEditCancel}.
      * @return A {@link Callback} that will return a TableCell that is able to 
      *      work on the type of element contained within the TableColumn.
      */
@@ -97,9 +98,9 @@
      *      type as the TableColumn. Note that it is up to the developer to set 
      *      {@link EventHandler event handlers} to listen to edit events in the 
      *      TableColumn, and react accordingly. Methods of interest include 
-     *      {@link TableColumn#setOnEditStart(EventHandler) setOnEditStart},
+     *      {@link TableColumn#setOnEditStart(javafx.event.EventHandler) setOnEditStart},
      *      {@link TableColumn#setOnEditCommit(javafx.event.EventHandler) setOnEditCommit}, 
-     *      and {@link TableColumn#setOnEditCancel(EventHandler) setOnEditCancel}.
+     *      and {@link TableColumn#setOnEditCancel(javafx.event.EventHandler) setOnEditCancel}.
      * @return A {@link Callback} that will return a TableCell that is able to 
      *      work on the type of element contained within the TableColumn.
      */
@@ -121,9 +122,9 @@
      *      type as the TableColumn. Note that it is up to the developer to set 
      *      {@link EventHandler event handlers} to listen to edit events in the 
      *      TableColumn, and react accordingly. Methods of interest include 
-     *      {@link TableColumn#setOnEditStart(EventHandler) setOnEditStart},
+     *      {@link TableColumn#setOnEditStart(javafx.event.EventHandler) setOnEditStart},
      *      {@link TableColumn#setOnEditCommit(javafx.event.EventHandler) setOnEditCommit}, 
-     *      and {@link TableColumn#setOnEditCancel(EventHandler) setOnEditCancel}.
+     *      and {@link TableColumn#setOnEditCancel(javafx.event.EventHandler) setOnEditCancel}.
      * @return A {@link Callback} that will return a TableCell that is able to 
      *      work on the type of element contained within the TableColumn.
      */
@@ -146,9 +147,9 @@
      *      type as the TableColumn. Note that it is up to the developer to set 
      *      {@link EventHandler event handlers} to listen to edit events in the 
      *      TableColumn, and react accordingly. Methods of interest include 
-     *      {@link TableColumn#setOnEditStart(EventHandler) setOnEditStart},
+     *      {@link TableColumn#setOnEditStart(javafx.event.EventHandler) setOnEditStart},
      *      {@link TableColumn#setOnEditCommit(javafx.event.EventHandler) setOnEditCommit}, 
-     *      and {@link TableColumn#setOnEditCancel(EventHandler) setOnEditCancel}.
+     *      and {@link TableColumn#setOnEditCancel(javafx.event.EventHandler) setOnEditCancel}.
      * @return A {@link Callback} that will return a TableCell that is able to 
      *      work on the type of element contained within the TableColumn.
      */
--- a/javafx-ui-controls/src/javafx/scene/control/cell/MapValueFactory.java	Tue Jul 03 14:35:20 2012 -0400
+++ b/javafx-ui-controls/src/javafx/scene/control/cell/MapValueFactory.java	Wed Jul 04 07:37:04 2012 +1200
@@ -34,9 +34,10 @@
 import javafx.beans.property.ReadOnlyObjectWrapper;
 import javafx.beans.property.ReadOnlyStringWrapper;
 import javafx.beans.value.ObservableValue;
+import javafx.scene.control.TableCell;
 import javafx.scene.control.TableColumn;
 import javafx.scene.control.TableColumn.CellDataFeatures;
-import javafx.scene.control.cell.PropertyValueFactory;
+import javafx.scene.control.TableView;
 import javafx.util.Callback;
 
 /**
--- a/javafx-ui-controls/src/javafx/scene/control/cell/TextFieldListCell.java	Tue Jul 03 14:35:20 2012 -0400
+++ b/javafx-ui-controls/src/javafx/scene/control/cell/TextFieldListCell.java	Wed Jul 04 07:37:04 2012 +1200
@@ -107,7 +107,11 @@
      **************************************************************************/    
     
     /**
-     * Creates a default TextFieldListCell with a null converter.
+     * Creates a default TextFieldListCell with a null converter. Without a 
+     * {@link StringConverter} specified, this cell will not be able to accept
+     * input from the TextField (as it will not know how to convert this back
+     * to the domain object). It is therefore strongly encouraged to not use
+     * this constructor unless you intend to set the converter separately.
      */
     public TextFieldListCell() { 
         this(null);
@@ -122,7 +126,7 @@
      * instance of type T. This item will then be passed along to the 
      * {@link ListView#onEditCommitProperty()} callback.
      * 
-     * @param onCommit A {@link StringConverter<T> converter} that can convert 
+     * @param converter A {@link StringConverter converter} that can convert 
      *      the given String (from what the user typed in) into an instance of 
      *      type T.
      */
--- a/javafx-ui-controls/src/javafx/scene/control/cell/TextFieldTableCell.java	Tue Jul 03 14:35:20 2012 -0400
+++ b/javafx-ui-controls/src/javafx/scene/control/cell/TextFieldTableCell.java	Wed Jul 04 07:37:04 2012 +1200
@@ -26,10 +26,7 @@
 
 import javafx.beans.property.ObjectProperty;
 import javafx.beans.property.SimpleObjectProperty;
-import javafx.scene.control.Label;
-import javafx.scene.control.TableCell;
-import javafx.scene.control.TableColumn;
-import javafx.scene.control.TextField;
+import javafx.scene.control.*;
 import javafx.util.Callback;
 import javafx.util.StringConverter;
 import javafx.util.converter.DefaultStringConverter;
@@ -55,8 +52,9 @@
     /**
      * Provides a {@link TextField} that allows editing of the cell content when
      * the cell is double-clicked, or when 
-     * {@link TableView#edit(int, TableColumn)} is called. This method will only 
-     * work on {@link TableColumn} instances which are of type String.
+     * {@link TableView#edit(int, javafx.scene.control.TableColumn)} is called. 
+     * This method will only  work on {@link TableColumn} instances which are of
+     * type String.
      * 
      * @return A {@link Callback} that can be inserted into the 
      *      {@link TableColumn#cellFactoryProperty() cell factory property} of a 
@@ -69,11 +67,11 @@
     /**
      * Provides a {@link TextField} that allows editing of the cell content when
      * the cell is double-clicked, or when 
-     * {@link TableView#edit(int, TableColumn)} is called. This method will work 
-     * on any {@link TableColumn} instance, regardless of its generic type. 
-     * However, to enable this, a {@link StringConverter} must be provided that will 
-     * convert the given String (from what the user typed in) into an instance 
-     * of type T. This item will then be passed along to the 
+     * {@link TableView#edit(int, javafx.scene.control.TableColumn) } is called. 
+     * This method will work  on any {@link TableColumn} instance, regardless of 
+     * its generic type. However, to enable this, a {@link StringConverter} must 
+     * be provided that will convert the given String (from what the user typed 
+     * in) into an instance of type T. This item will then be passed along to the 
      * {@link TableColumn#onEditCommitProperty()} callback.
      * 
      * @param converter A {@link StringConverter} that can convert the given String 
@@ -109,7 +107,11 @@
      **************************************************************************/
 
     /**
-     * Creates a default TextFieldTableCell with a null converter.
+     * Creates a default TextFieldTableCell with a null converter. Without a 
+     * {@link StringConverter} specified, this cell will not be able to accept
+     * input from the TextField (as it will not know how to convert this back
+     * to the domain object). It is therefore strongly encouraged to not use
+     * this constructor unless you intend to set the converter separately.
      */
     public TextFieldTableCell() { 
         this(null);
@@ -124,7 +126,7 @@
      * instance of type T. This item will then be passed along to the 
      * {@link TableColumn#onEditCommitProperty()} callback.
      * 
-     * @param onCommit A {@link StringConverter<T> converter} that can convert 
+     * @param converter A {@link StringConverter converter} that can convert 
      *      the given String (from what the user typed in) into an instance of 
      *      type T.
      */
--- a/javafx-ui-controls/src/javafx/scene/control/cell/TextFieldTreeCell.java	Tue Jul 03 14:35:20 2012 -0400
+++ b/javafx-ui-controls/src/javafx/scene/control/cell/TextFieldTreeCell.java	Wed Jul 04 07:37:04 2012 +1200
@@ -42,7 +42,7 @@
  * being edited, and as a TextField when in editing mode. The TextField will, by 
  * default, stretch to fill the entire tree cell.
  * 
- * @param <T> The type of the elements contained within the ListView.
+ * @param <T> The type of the elements contained within the TreeView.
  */
 public class TextFieldTreeCell<T> extends TreeCell<T> {
     
@@ -54,7 +54,8 @@
     
     /**
      * Provides a {@link TextField} that allows editing of the cell content when 
-     * the cell is double-clicked, or when {@link ListView#edit(int)} is called. 
+     * the cell is double-clicked, or when 
+     * {@link TreeView#edit(javafx.scene.control.TreeItem)} is called. 
      * This method will only work on {@link TreeView} instances which are of 
      * type String.
      * 
@@ -111,7 +112,11 @@
      **************************************************************************/
     
     /**
-     * Creates a default TextFieldTreeCell with a null converter.
+     * Creates a default TextFieldTreeCell with a null converter. Without a 
+     * {@link StringConverter} specified, this cell will not be able to accept
+     * input from the TextField (as it will not know how to convert this back
+     * to the domain object). It is therefore strongly encouraged to not use
+     * this constructor unless you intend to set the converter separately.
      */
     public TextFieldTreeCell() { 
         this(null);
@@ -126,7 +131,7 @@
      * instance of type T. This item will then be passed along to the 
      * {@link TreeView#onEditCommitProperty()} callback.
      * 
-     * @param onCommit A {@link StringConverter<T> converter} that can convert 
+     * @param converter A {@link StringConverter converter} that can convert 
      *      the given String (from what the user typed in) into an instance of 
      *      type T.
      */