changeset 2869:1e8ef92fe45a

Re-enabling the keyboard input tests for ListView, TreeView, TableView and TreeTableView. Hopefully they don't bring the test infrastructure down again (either by failing on certain platforms or by causing OOME). In any case, if they fail to work they can be @Ignored again, but ideally they would be kept intact and running as they cover a lot of finicky keyboard interaction issues and will help prevent regressions (and I have to write a bunch more tests in the coming weeks for this area too).
author jgiles
date Mon, 11 Mar 2013 15:55:38 +1300
parents 7680e1b9d790
children 02a668fbc3b6
files javafx-ui-controls/test/javafx/scene/control/ListViewKeyInputTest.java javafx-ui-controls/test/javafx/scene/control/TableViewKeyInputTest.java javafx-ui-controls/test/javafx/scene/control/TreeTableViewKeyInputTest.java javafx-ui-controls/test/javafx/scene/control/TreeViewKeyInputTest.java
diffstat 4 files changed, 4 insertions(+), 5 deletions(-) [+]
line wrap: on
line diff
--- a/javafx-ui-controls/test/javafx/scene/control/ListViewKeyInputTest.java	Mon Mar 11 15:14:39 2013 +1300
+++ b/javafx-ui-controls/test/javafx/scene/control/ListViewKeyInputTest.java	Mon Mar 11 15:55:38 2013 +1300
@@ -27,7 +27,6 @@
 
 import com.sun.javafx.Utils;
 import com.sun.javafx.scene.control.behavior.ListViewAnchorRetriever;
-import com.sun.javafx.tk.Toolkit;
 import static org.junit.Assert.*;
 
 import java.util.List;
@@ -42,7 +41,7 @@
 import org.junit.Ignore;
 import org.junit.Test;
 
-@Ignore("Disabling tests as they fail with OOM in continuous builds")
+//@Ignore("Disabling tests as they fail with OOM in continuous builds")
 public class ListViewKeyInputTest {
     private ListView<String> listView;
     private MultipleSelectionModel<String> sm;
--- a/javafx-ui-controls/test/javafx/scene/control/TableViewKeyInputTest.java	Mon Mar 11 15:14:39 2013 +1300
+++ b/javafx-ui-controls/test/javafx/scene/control/TableViewKeyInputTest.java	Mon Mar 11 15:55:38 2013 +1300
@@ -42,7 +42,7 @@
 import org.junit.Ignore;
 import org.junit.Test;
 
-@Ignore("Disabling tests as they fail with OOM in continuous builds")
+//@Ignore("Disabling tests as they fail with OOM in continuous builds")
 public class TableViewKeyInputTest {
     private TableView<String> tableView;
     private TableView.TableViewSelectionModel<String> sm;
--- a/javafx-ui-controls/test/javafx/scene/control/TreeTableViewKeyInputTest.java	Mon Mar 11 15:14:39 2013 +1300
+++ b/javafx-ui-controls/test/javafx/scene/control/TreeTableViewKeyInputTest.java	Mon Mar 11 15:55:38 2013 +1300
@@ -41,7 +41,7 @@
 import org.junit.Ignore;
 import org.junit.Test;
 
-@Ignore("Disabling tests as they fail with OOM in continuous builds")
+//@Ignore("Disabling tests as they fail with OOM in continuous builds")
 public class TreeTableViewKeyInputTest {
     private TreeTableView<String> tableView;
     private TreeTableView.TreeTableViewSelectionModel<String> sm;
--- a/javafx-ui-controls/test/javafx/scene/control/TreeViewKeyInputTest.java	Mon Mar 11 15:14:39 2013 +1300
+++ b/javafx-ui-controls/test/javafx/scene/control/TreeViewKeyInputTest.java	Mon Mar 11 15:55:38 2013 +1300
@@ -41,7 +41,7 @@
 import org.junit.Ignore;
 import org.junit.Test;
 
-@Ignore("Disabling tests as they fail with OOM in continuous builds")
+//@Ignore("Disabling tests as they fail with OOM in continuous builds")
 public class TreeViewKeyInputTest {
     private TreeView<String> treeView;
     private MultipleSelectionModel<TreeItem<String>> sm;