changeset 4303:74ac20176fc5

Automated merge with ssh://jfxsrc.us.oracle.com//javafx/8.0/scrum/graphics/jfx////rt
author Martin Sladecek <martin.sladecek@oracle.com>
date Tue, 16 Jul 2013 13:35:31 +0200
parents 66df77e2c6b2 57ddbe09941c
children a61b939ac01b 90eb5c049031
files
diffstat 4 files changed, 56 insertions(+), 35 deletions(-) [+]
line wrap: on
line diff
--- a/modules/base/src/main/java/javafx/beans/binding/BooleanBinding.java	Tue Jul 16 14:26:23 2013 +0300
+++ b/modules/base/src/main/java/javafx/beans/binding/BooleanBinding.java	Tue Jul 16 13:35:31 2013 +0200
@@ -51,44 +51,50 @@
  * {@link #get()} is called for an invalid binding.
  * <p>
  * See {@link DoubleBinding} for an example how this base class can be extended.
- * 
+ *
  * @see Binding
  * @see javafx.beans.binding.BooleanExpression
- * 
+ *
  * @since JavaFX 2.0
  */
 public abstract class BooleanBinding extends BooleanExpression implements
         Binding<Boolean> {
 
+    /**
+     * Sole constructor
+     */
+    public BooleanBinding() {
+    }
+
     private boolean value;
     private boolean valid = false;
     private BindingHelperObserver observer;
     private ExpressionHelper<Boolean> helper = null;
 
-    @Override 
+    @Override
     public void addListener(InvalidationListener listener) {
         helper = ExpressionHelper.addListener(helper, this, listener);
     }
 
-    @Override 
+    @Override
     public void removeListener(InvalidationListener listener) {
         helper = ExpressionHelper.removeListener(helper, listener);
     }
-    
+
     @Override
     public void addListener(ChangeListener<? super Boolean> listener) {
         helper = ExpressionHelper.addListener(helper, this, listener);
     }
 
-    @Override 
+    @Override
     public void removeListener(ChangeListener<? super Boolean> listener) {
         helper = ExpressionHelper.removeListener(helper, listener);
     }
-    
+
     /**
      * Start observing the dependencies for changes. If the value of one of the
      * dependencies changes, the binding is marked as invalid.
-     * 
+     *
      * @param dependencies
      *            the dependencies to observe
      */
@@ -105,7 +111,7 @@
 
     /**
      * Stop observing the dependencies for changes.
-     * 
+     *
      * @param dependencies
      *            the dependencies to stop observing
      */
@@ -128,7 +134,7 @@
     /**
      * A default implementation of {@code getDependencies()} that returns an
      * empty {@link javafx.collections.ObservableList}.
-     * 
+     *
      * @return an empty {@code ObservableList}
      */
     @Override
@@ -142,7 +148,7 @@
      * {@code computeValue()} is only called if the binding is invalid. The
      * result is cached and returned if the binding did not become invalid since
      * the last call of {@code get()}.
-     * 
+     *
      * @return the current value
      */
     @Override
@@ -181,7 +187,7 @@
      * <p>
      * Classes extending {@code BooleanBinding} have to provide an
      * implementation of {@code computeValue}.
-     * 
+     *
      * @return the current value
      */
     protected abstract boolean computeValue();
@@ -189,7 +195,7 @@
     /**
      * Returns a string representation of this {@code BooleanBinding} object.
      * @return a string representation of this {@code BooleanBinding} object.
-     */ 
+     */
     @Override
     public String toString() {
         return valid ? "BooleanBinding [value: " + get() + "]"
--- a/modules/base/src/main/java/javafx/beans/binding/BooleanExpression.java	Tue Jul 16 14:26:23 2013 +0300
+++ b/modules/base/src/main/java/javafx/beans/binding/BooleanExpression.java	Tue Jul 16 13:35:31 2013 +0200
@@ -45,6 +45,12 @@
  */
 public abstract class BooleanExpression implements ObservableBooleanValue {
 
+    /**
+     * Sole constructor
+     */
+    public BooleanExpression() {
+    }
+
     @Override
     public Boolean getValue() {
         return get();
@@ -57,7 +63,7 @@
      * will be returned. Otherwise a new
      * {@link javafx.beans.binding.BooleanBinding} is created that is bound to
      * the {@code ObservableBooleanValue}.
-     * 
+     *
      * @param value
      *            The source {@code ObservableBooleanValue}
      * @return A {@code BooleanExpression} that wraps the
@@ -93,7 +99,7 @@
                     }
                 };
     }
-    
+
     /**
      * Returns a {@code BooleanExpression} that wraps an
      * {@link javafx.beans.value.ObservableValue}. If the
@@ -101,9 +107,9 @@
      * will be returned. Otherwise a new
      * {@link javafx.beans.binding.BooleanBinding} is created that is bound to
      * the {@code ObservableValue}.
-     * 
+     *
      * Note: null values will be interpreted as "false".
-     * 
+     *
      * @param value
      *            The source {@code ObservableValue}
      * @return A {@code BooleanExpression} that wraps the
@@ -145,7 +151,7 @@
      * Creates a new {@code BooleanExpression} that performs the conditional
      * AND-operation on this {@code BooleanExpression} and a
      * {@link ObservableBooleanValue}.
-     * 
+     *
      * @param other
      *            the other {@code ObservableBooleanValue}
      * @return the new {@code BooleanExpression}
@@ -160,7 +166,7 @@
      * Creates a new {@code BooleanExpression} that performs the conditional
      * OR-operation on this {@code BooleanExpression} and a
      * {@link ObservableBooleanValue}.
-     * 
+     *
      * @param other
      *            the other {@code ObservableBooleanValue}
      * @return the new {@code BooleanExpression}
@@ -174,7 +180,7 @@
     /**
      * Creates a new {@code BooleanExpression} that calculates the negation of
      * this {@code BooleanExpression}.
-     * 
+     *
      * @return the new {@code BooleanExpression}
      */
     public BooleanBinding not() {
@@ -184,7 +190,7 @@
     /**
      * Creates a new {@code BooleanExpression} that holds {@code true} if this and
      * another {@link javafx.beans.value.ObservableBooleanValue} are equal.
-     * 
+     *
      * @param other
      *            the other {@code ObservableBooleanValue}
      * @return the new {@code BooleanExpression}
@@ -198,7 +204,7 @@
     /**
      * Creates a new {@code BooleanExpression} that holds {@code true} if this and
      * another {@link javafx.beans.value.ObservableBooleanValue} are equal.
-     * 
+     *
      * @param other
      *            the other {@code ObservableBooleanValue}
      * @return the new {@code BooleanExpression}
@@ -214,19 +220,19 @@
      * of this {@code BooleanExpression} turned into a {@code String}. If the
      * value of this {@code BooleanExpression} changes, the value of the
      * {@code StringBinding} will be updated automatically.
-     * 
+     *
      * @return the new {@code StringBinding}
      */
     public StringBinding asString() {
         return (StringBinding) StringFormatter.convert(this);
     }
-    
+
     /**
      * Creates an {@link javafx.beans.binding.ObjectExpression} that holds the value
      * of this {@code BooleanExpression}. If the
      * value of this {@code BooleanExpression} changes, the value of the
      * {@code ObjectExpression} will be updated automatically.
-     * 
+     *
      * @return the new {@code ObjectExpression}
      * @since JavaFX 8.0
      */
--- a/modules/base/src/main/java/javafx/beans/property/BooleanProperty.java	Tue Jul 16 14:26:23 2013 +0300
+++ b/modules/base/src/main/java/javafx/beans/property/BooleanProperty.java	Tue Jul 16 13:35:31 2013 +0200
@@ -60,6 +60,12 @@
         Property<Boolean>, WritableBooleanValue {
 
     /**
+     * Sole constructor
+     */
+    public BooleanProperty() {
+    }
+
+    /**
      * {@inheritDoc}
      */
     @Override
--- a/modules/graphics/src/main/java/javafx/animation/AnimationTimer.java	Tue Jul 16 14:26:23 2013 +0300
+++ b/modules/graphics/src/main/java/javafx/animation/AnimationTimer.java	Tue Jul 16 13:35:31 2013 +0200
@@ -31,34 +31,37 @@
 /**
  * The class {@code AnimationTimer} allows to create a timer, that is called in
  * each frame while it is active.
- * 
+ *
  * An extending class has to override the method {@link #handle(long)} which
  * will be called in every frame.
- * 
+ *
  * The methods {@link AnimationTimer#start()} and {@link #stop()} allow to start
  * and stop the timer.
- * 
- * 
+ *
+ *
  * @since JavaFX 2.0
  */
 public abstract class AnimationTimer {
-    
+
     private final AbstractMasterTimer timer;
     private boolean active;
-    
+
+    /**
+     * Creates a new timer.
+     */
     public AnimationTimer() {
         timer = Toolkit.getToolkit().getMasterTimer();
     }
-    
+
     // For testing only
     AnimationTimer(AbstractMasterTimer timer) {
         this.timer = timer;
     }
-    
+
     /**
      * This method needs to be overridden by extending classes. It is going to
      * be called in every frame while the {@code AnimationTimer} is active.
-     * 
+     *
      * @param now
      *            The timestamp of the current frame given in nanoseconds. This
      *            value will be the same for all {@code AnimationTimers} called
@@ -70,7 +73,7 @@
      * Starts the {@code AnimationTimers}. Once it is started, the
      * {@link #handle(long)} method of this {@code AnimationTimers} will be
      * called in every frame.
-     * 
+     *
      * The {@code AnimationTimers} can be stopped by calling {@link #stop()}.
      */
     public void start() {