changeset 52581:f642ede2eb07

8213795: Force explicit null check on patching placeholder offset Reviewed-by: kvn, adinn
author rkennke
date Wed, 14 Nov 2018 18:57:47 +0100
parents 08a0bf1592bd
children f5011100c920
files src/hotspot/share/asm/assembler.cpp
diffstat 1 files changed, 11 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/src/hotspot/share/asm/assembler.cpp	Fri Nov 09 10:34:19 2018 -0300
+++ b/src/hotspot/share/asm/assembler.cpp	Wed Nov 14 18:57:47 2018 +0100
@@ -333,6 +333,17 @@
 }
 
 bool MacroAssembler::needs_explicit_null_check(intptr_t offset) {
+  // The offset -1 is used (hardcoded) in a number of places in C1 and MacroAssembler
+  // to indicate an unknown offset. For example, TemplateTable::pop_and_check_object(Register r)
+  // calls MacroAssembler::null_check(Register reg, int offset = -1) which gets here
+  // with -1. Another example is GraphBuilder::access_field(...) which uses -1 as placeholder
+  // for offsets to be patched in later. The -1 there means the offset is not yet known
+  // and may lie outside of the zero-trapping page, and thus we need to ensure we're forcing
+  // an explicit null check for -1, even if it may otherwise be in the range
+  // [-cell_header_size, os::vm_page_size).
+  // TODO: Find and replace all relevant uses of -1 with a reasonably named constant.
+  if (offset == -1) return true;
+
   // Check if offset is outside of [-cell_header_size, os::vm_page_size)
   return offset < -Universe::heap()->cell_header_size() ||
          offset >= os::vm_page_size();