changeset 8089:09484e9f83b7

8005521: StressMethodComparator is not thread-safe Summary: Remove the debug option. It isn't correct or tested. Reviewed-by: gtriantafill, dholmes, sspitsyn
author coleenp
date Thu, 19 Mar 2015 09:47:27 -0400
parents bc4a7ba13b1d
children 9273f2b75c19
files src/share/vm/oops/instanceKlass.cpp src/share/vm/runtime/globals.hpp
diffstat 2 files changed, 0 insertions(+), 20 deletions(-) [+]
line wrap: on
line diff
--- a/src/share/vm/oops/instanceKlass.cpp	Wed Mar 18 17:45:47 2015 -0400
+++ b/src/share/vm/oops/instanceKlass.cpp	Thu Mar 19 09:47:27 2015 -0400
@@ -716,23 +716,6 @@
 
     // Set up method entry points for compiler and interpreter    .
     m->link_method(m, CHECK);
-
-    // This is for JVMTI and unrelated to relocator but the last thing we do
-#ifdef ASSERT
-    if (StressMethodComparator) {
-      ResourceMark rm(THREAD);
-      static int nmc = 0;
-      for (int j = i; j >= 0 && j >= i-4; j--) {
-        if ((++nmc % 1000) == 0)  tty->print_cr("Have run MethodComparator %d times...", nmc);
-        bool z = MethodComparator::methods_EMCP(m(),
-                   methods()->at(j));
-        if (j == i && !z) {
-          tty->print("MethodComparator FAIL: "); m->print(); m->print_codes();
-          assert(z, "method must compare equal to itself");
-        }
-      }
-    }
-#endif //ASSERT
   }
 }
 
--- a/src/share/vm/runtime/globals.hpp	Wed Mar 18 17:45:47 2015 -0400
+++ b/src/share/vm/runtime/globals.hpp	Thu Mar 19 09:47:27 2015 -0400
@@ -1342,9 +1342,6 @@
   product(intx, TraceRedefineClasses, 0,                                    \
           "Trace level for JVMTI RedefineClasses")                          \
                                                                             \
-  develop(bool, StressMethodComparator, false,                              \
-          "Run the MethodComparator on all loaded methods")                 \
-                                                                            \
   /* change to false by default sometime after Mustang */                   \
   product(bool, VerifyMergedCPBytecodes, true,                              \
           "Verify bytecodes after RedefineClasses constant pool merging")   \