changeset 10444:3a8da1230500

8149557: Resource mark breaks printing to string stream Reviewed-by: stuefe, dholmes
author goetz
date Sun, 06 Mar 2016 15:50:13 -0500
parents 27b6bff990d5
children 57175b61dac3
files src/share/vm/oops/symbol.cpp src/share/vm/utilities/ostream.cpp
diffstat 2 files changed, 17 insertions(+), 3 deletions(-) [+]
line wrap: on
line diff
--- a/src/share/vm/oops/symbol.cpp	Thu Mar 03 17:33:13 2016 +0000
+++ b/src/share/vm/oops/symbol.cpp	Sun Mar 06 15:50:13 2016 -0500
@@ -158,9 +158,21 @@
 }
 
 void Symbol::print_symbol_on(outputStream* st) const {
-  ResourceMark rm;
+  char *s;
   st = st ? st : tty;
-  st->print("%s", as_quoted_ascii());
+  {
+    // ResourceMark may not affect st->print(). If st is a string
+    // stream it could resize, using the same resource arena.
+    ResourceMark rm;
+    s = as_quoted_ascii();
+    s = os::strdup(s);
+  }
+  if (s == NULL) {
+    st->print("(null)");
+  } else {
+    st->print("%s", s);
+    os::free(s);
+  }
 }
 
 char* Symbol::as_quoted_ascii() const {
--- a/src/share/vm/utilities/ostream.cpp	Thu Mar 03 17:33:13 2016 +0000
+++ b/src/share/vm/utilities/ostream.cpp	Sun Mar 06 15:50:13 2016 -0500
@@ -338,7 +338,9 @@
       }
       char* oldbuf = buffer;
       assert(rm == NULL || Thread::current()->current_resource_mark() == rm,
-             "stringStream is re-allocated with a different ResourceMark");
+             "StringStream is re-allocated with a different ResourceMark. Current: "
+             PTR_FORMAT " original: " PTR_FORMAT,
+             p2i(Thread::current()->current_resource_mark()), p2i(rm));
       buffer = NEW_RESOURCE_ARRAY(char, end);
       if (buffer_pos > 0) {
         memcpy(buffer, oldbuf, buffer_pos);