changeset 13503:d9ec6f177df2

Merge
author iignatyev
date Sat, 12 Aug 2017 02:13:29 +0200
parents 9bfa14d74ad3 122d8b165f68
children 0f79b4463de7
files
diffstat 2 files changed, 41 insertions(+), 19 deletions(-) [+]
line wrap: on
line diff
--- a/src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/Main.java	Fri Aug 11 23:12:11 2017 +0000
+++ b/src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/Main.java	Sat Aug 12 02:13:29 2017 +0200
@@ -247,7 +247,7 @@
 
     public static class Options {
         public List<SearchFor> files = new LinkedList<>();
-        public String outputName = "unnamed.so";
+        public String outputName = defaultOutputName();
         public String methodList;
         public List<ClassSource> sources = new ArrayList<>();
         public String linkerpath = null;
@@ -269,6 +269,30 @@
         public boolean version;
         public boolean compileWithAssertions;
         public boolean tiered;
+
+        private static String defaultOutputName() {
+            String osName = System.getProperty("os.name");
+            String name = "unnamed.";
+            String ext;
+
+            switch (osName) {
+                case "Linux":
+                case "SunOS":
+                    ext = "so";
+                    break;
+                case "Mac OS X":
+                    ext = "dylib";
+                    break;
+                default:
+                    if (osName.startsWith("Windows")) {
+                        ext = "dll";
+                    } else {
+                        ext = "so";
+                    }
+            }
+
+            return name + ext;
+        }
     }
 
     /* package */final Options options = new Options();
@@ -529,45 +553,41 @@
             String name = options.outputName;
             String objectFileName = name;
 
-            // [TODO] The jtregs tests expect .so extension so don't
-            // override with platform specific file extension until the
-            // tests are fixed.
             String libraryFileName = name;
 
             String linkerCmd;
             String linkerPath;
             String osName = System.getProperty("os.name");
 
-            if (name.endsWith(".so")) {
-                objectFileName = name.substring(0, name.length() - ".so".length());
-            } else if (name.endsWith(".dylib")) {
-                objectFileName = name.substring(0, name.length() - ".dylib".length());
-            } else if (name.endsWith(".dll")) {
-                objectFileName = name.substring(0, name.length() - ".dll".length());
-            }
-
             switch (osName) {
                 case "Linux":
-                    // libraryFileName = options.outputName + ".so";
-                    objectFileName = objectFileName + ".o";
+                    if (name.endsWith(".so")) {
+                        objectFileName = name.substring(0, name.length() - ".so".length());
+                    }
                     linkerPath = (options.linkerpath != null) ? options.linkerpath : "ld";
                     linkerCmd = linkerPath + " -shared -z noexecstack -o " + libraryFileName + " " + objectFileName;
                     break;
                 case "SunOS":
-                    // libraryFileName = options.outputName + ".so";
+                    if (name.endsWith(".so")) {
+                        objectFileName = name.substring(0, name.length() - ".so".length());
+                    }
                     objectFileName = objectFileName + ".o";
                     linkerPath = (options.linkerpath != null) ? options.linkerpath : "ld";
                     linkerCmd = linkerPath + " -shared -o " + libraryFileName + " " + objectFileName;
                     break;
                 case "Mac OS X":
-                    // libraryFileName = options.outputName + ".dylib";
+                    if (name.endsWith(".dylib")) {
+                        objectFileName = name.substring(0, name.length() - ".dylib".length());
+                    }
                     objectFileName = objectFileName + ".o";
                     linkerPath = (options.linkerpath != null) ? options.linkerpath : "ld";
                     linkerCmd = linkerPath + " -dylib -o " + libraryFileName + " " + objectFileName;
                     break;
                 default:
                     if (osName.startsWith("Windows")) {
-                        // libraryFileName = options.outputName + ".dll";
+                        if (name.endsWith(".dll")) {
+                            objectFileName = name.substring(0, name.length() - ".dll".length());
+                        }
                         objectFileName = objectFileName + ".obj";
                         linkerPath = (options.linkerpath != null) ? options.linkerpath : getWindowsLinkPath();
                         if (linkerPath == null) {
@@ -575,8 +595,9 @@
                         }
                         linkerCmd = linkerPath + " /DLL /OPT:NOREF /NOLOGO /NOENTRY" + " /OUT:" + libraryFileName + " " + objectFileName;
                         break;
-                    } else
+                    } else {
                         throw new InternalError("Unsupported platform: " + osName);
+                    }
             }
 
             try (Timer t = new Timer(this, "Creating binary: " + objectFileName)) {
--- a/test/compiler/aot/cli/jaotc/JaotcTestHelper.java	Fri Aug 11 23:12:11 2017 +0000
+++ b/test/compiler/aot/cli/jaotc/JaotcTestHelper.java	Sat Aug 12 02:13:29 2017 +0200
@@ -26,13 +26,14 @@
 import java.io.File;
 import java.io.IOException;
 import jdk.test.lib.process.ExitCode;
+import jdk.test.lib.Platform;
 import jdk.test.lib.JDKToolLauncher;
 import jdk.test.lib.Utils;
 import jdk.test.lib.cli.CommandLineOptionTest;
 import jdk.test.lib.process.OutputAnalyzer;
 
 public class JaotcTestHelper {
-    public static final String DEFAULT_LIB_PATH = "./unnamed.so";
+    public static final String DEFAULT_LIB_PATH = "./unnamed." + Platform.sharedLibraryExt();
     public static final String DEFAULT_LIBRARY_LOAD_MESSAGE = "loaded    " + DEFAULT_LIB_PATH
             + "  aot library";
     private static final String ENABLE_AOT = "-XX:+UseAOT";