changeset 17765:17d2d44e306c

8182031: Swing's ComboBox Popup opens and closes immediately Reviewed-by: azvegint
author psadhukhan
date Fri, 16 Jun 2017 11:07:45 +0530
parents 905ba4e83b0c
children 0ec14d6528ef
files src/java.desktop/share/classes/javax/swing/plaf/basic/BasicComboPopup.java test/javax/swing/JComboBox/8182031/ComboPopupTest.java
diffstat 2 files changed, 100 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicComboPopup.java	Thu Jun 15 17:13:33 2017 +0530
+++ b/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicComboPopup.java	Fri Jun 16 11:07:45 2017 +0530
@@ -911,7 +911,7 @@
             // JComboBox mouse listener
             Component source = (Component)e.getSource();
             Dimension size = source.getSize();
-            Rectangle bounds = new Rectangle( 0, 0, size.width - 1, size.height - 1 );
+            Rectangle bounds = new Rectangle( 0, 0, size.width, size.height);
             if ( !bounds.contains( e.getPoint() ) ) {
                 MouseEvent newEvent = convertMouseEvent( e );
                 Point location = newEvent.getPoint();
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/test/javax/swing/JComboBox/8182031/ComboPopupTest.java	Fri Jun 16 11:07:45 2017 +0530
@@ -0,0 +1,99 @@
+/*
+ * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+/*
+ * @test
+ * @bug 8182031
+ * @summary  Verifies if ComboBox Popup opens and closes immediately
+ * @run main ComboPopupTest
+ */
+import java.awt.Container;
+import java.awt.Dimension;
+import java.awt.FlowLayout;
+import java.awt.Point;
+import java.awt.Robot;
+import java.awt.event.InputEvent;
+import javax.swing.JComboBox;
+import javax.swing.JComponent;
+import javax.swing.JFrame;
+import javax.swing.SwingUtilities;
+
+public class ComboPopupTest {
+    JFrame frame = null;
+    JComboBox<String> comboBox = null;
+    private volatile Point p = null;
+    private volatile Dimension d = null;
+
+    void blockTillDisplayed(JComponent comp) throws Exception {
+        while (p == null) {
+            try {
+                SwingUtilities.invokeAndWait(() -> {
+                    p = comp.getLocationOnScreen();
+                    d = comboBox.getSize();
+                });
+            } catch (IllegalStateException e) {
+                try {
+                    Thread.sleep(1000);
+                } catch (InterruptedException ie) {
+                }
+            }
+        }
+    }
+
+    public static void main(String[] args) throws Exception {
+        new ComboPopupTest();
+    }
+
+    public ComboPopupTest() throws Exception {
+        try {
+            Robot robot = new Robot();
+            robot.setAutoDelay(200);
+            SwingUtilities.invokeAndWait(() -> start());
+            blockTillDisplayed(comboBox);
+            robot.waitForIdle();
+            robot.mouseMove(p.x + d.width-1, p.y + d.height/2);
+            robot.mousePress(InputEvent.BUTTON1_MASK);
+            robot.mouseRelease(InputEvent.BUTTON1_MASK);
+            robot.waitForIdle();
+
+            System.out.println("popmenu visible " + comboBox.isPopupVisible());
+            if (!comboBox.isPopupVisible()) {
+                throw new RuntimeException("combobox popup is not visible");
+            }
+        } finally {
+            SwingUtilities.invokeAndWait(()->frame.dispose());
+        }
+    }
+
+    public void start() {
+        frame = new JFrame();
+        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
+        Container contentPane = frame.getContentPane();
+        comboBox = new JComboBox<String>(new String[] { "Item 1", "Item 2", "Item 3", "Item 4" });
+        contentPane.setLayout(new FlowLayout());
+        contentPane.add(comboBox);
+        frame.setLocationRelativeTo(null);
+        frame.pack();
+        frame.setVisible(true);
+    }
+}
+