OpenJDK / zgc / zgc
changeset 3975:097245f7db08
6875716: JLayer.remove((Component)null) should behave consistently in (not) throwing NPE
Reviewed-by: rupashka
author | alexp |
---|---|
date | Tue, 15 Sep 2009 16:26:40 +0400 |
parents | 711cc3e0bd63 |
children | 6758b915b581 |
files | jdk/src/share/classes/javax/swing/JLayer.java jdk/test/javax/swing/JLayer/6875716/bug6875716.java |
diffstat | 2 files changed, 49 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/jdk/src/share/classes/javax/swing/JLayer.java Thu Sep 10 12:30:55 2009 +0400 +++ b/jdk/src/share/classes/javax/swing/JLayer.java Tue Sep 15 16:26:40 2009 +0400 @@ -333,7 +333,9 @@ * {@inheritDoc} */ public void remove(Component comp) { - if (comp == getView()) { + if (comp == null) { + super.remove(comp); + } else if (comp == getView()) { setView(null); } else if (comp == getGlassPane()) { setGlassPane(null);
--- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/jdk/test/javax/swing/JLayer/6875716/bug6875716.java Tue Sep 15 16:26:40 2009 +0400 @@ -0,0 +1,46 @@ +/* + * Copyright 2009 Sun Microsystems, Inc. All Rights Reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara, + * CA 95054 USA or visit www.sun.com if you need additional information or + * have any questions. + */ + +/* @test + * @bug 6875716 + * @summary JLayer.remove((Component)null) should behave consistently in (not) throwing NPE + * @author Alexander Potochkin + */ + +import javax.swing.*; +import java.awt.*; + +public class bug6875716 { + + public static void main(String[] args) throws Exception { + JLayer<Component> layer = new JLayer<Component>(new Component(){}); + layer.setGlassPane(null); + try { + layer.remove((Component)null); + } catch (NullPointerException e) { + //this is what we expect + return; + } + throw new RuntimeException("Test failed"); + } +}