changeset 2289:c2323e2ea62b

6385687: UseFastEmptyMethods/UseFastAccessorMethods considered harmful Reviewed-by: kvn, jrose, phh
author never
date Thu, 31 Mar 2011 21:05:55 -0700
parents 8010c8c623ac
children f8b038506985
files src/share/vm/prims/jvmtiManageCapabilities.cpp src/share/vm/runtime/globals.hpp
diffstat 2 files changed, 7 insertions(+), 4 deletions(-) [+]
line wrap: on
line diff
--- a/src/share/vm/prims/jvmtiManageCapabilities.cpp	Thu Mar 31 16:54:27 2011 -0700
+++ b/src/share/vm/prims/jvmtiManageCapabilities.cpp	Thu Mar 31 21:05:55 2011 -0700
@@ -319,8 +319,11 @@
   bool enter_all_methods =
     interp_events ||
     avail.can_generate_breakpoint_events;
-  UseFastEmptyMethods = !enter_all_methods;
-  UseFastAccessorMethods = !enter_all_methods;
+  if (enter_all_methods) {
+    // Disable these when tracking the bytecodes
+    UseFastEmptyMethods = false;
+    UseFastAccessorMethods = false;
+  }
 
   if (avail.can_generate_breakpoint_events) {
     RewriteFrequentPairs = false;
--- a/src/share/vm/runtime/globals.hpp	Thu Mar 31 16:54:27 2011 -0700
+++ b/src/share/vm/runtime/globals.hpp	Thu Mar 31 21:05:55 2011 -0700
@@ -2726,10 +2726,10 @@
   product(bool, UseLoopCounter, true,                                       \
           "Increment invocation counter on backward branch")                \
                                                                             \
-  product(bool, UseFastEmptyMethods, true,                                  \
+  product(bool, UseFastEmptyMethods, false,                                 \
           "Use fast method entry code for empty methods")                   \
                                                                             \
-  product(bool, UseFastAccessorMethods, true,                               \
+  product(bool, UseFastAccessorMethods, false,                              \
           "Use fast method entry code for accessor methods")                \
                                                                             \
   product_pd(bool, UseOnStackReplacement,                                   \