changeset 12268:dab623e5a387

8167300: Scheduling failures during gcm should be fatal Reviewed-by: kvn, mcberg
author roland
date Mon, 10 Oct 2016 17:04:42 +0200
parents c09080eab7ac
children 916006f85f92 9ea71fc781fe
files src/share/vm/opto/gcm.cpp src/share/vm/opto/lcm.cpp
diffstat 2 files changed, 5 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/src/share/vm/opto/gcm.cpp	Thu Oct 13 12:27:39 2016 +0200
+++ b/src/share/vm/opto/gcm.cpp	Mon Oct 10 17:04:42 2016 +0200
@@ -297,6 +297,7 @@
         int is_visited = visited.test_set(in->_idx);
         if (!has_block(in)) {
           if (is_visited) {
+            assert(false, "graph should be schedulable");
             return false;
           }
           // Save parent node and next input's index.
@@ -1129,6 +1130,7 @@
 
     if (LCA == NULL) {
       // Bailout without retry
+      assert(false, "graph should be schedulable");
       C->record_method_not_compilable("late schedule failed: LCA == NULL");
       return least;
     }
@@ -1283,6 +1285,7 @@
         C->record_failure(C2Compiler::retry_no_subsuming_loads());
       } else {
         // Bailout without retry when (early->_dom_depth > LCA->_dom_depth)
+        assert(false, "graph should be schedulable");
         C->record_method_not_compilable("late schedule failed: incorrect graph");
       }
       return;
--- a/src/share/vm/opto/lcm.cpp	Thu Oct 13 12:27:39 2016 +0200
+++ b/src/share/vm/opto/lcm.cpp	Mon Oct 10 17:04:42 2016 +0200
@@ -1147,6 +1147,8 @@
       // If this is the first failure, the sentinel string will "stick"
       // to the Compile object, and the C2Compiler will see it and retry.
       C->record_failure(C2Compiler::retry_no_subsuming_loads());
+    } else {
+      assert(false, "graph should be schedulable");
     }
     // assert( phi_cnt == end_idx(), "did not schedule all" );
     return false;