OpenJDK / bsd-port / jdk9 / hotspot
changeset 8829:af60f1cb36f2
8011858: Use Compile::live_nodes() instead of Compile::unique() in appropriate places
Reviewed-by: kvn, vlivanov
Contributed-by: vlad.ureche@gmail.com
author | kvn |
---|---|
date | Mon, 10 Aug 2015 10:39:19 -0700 |
parents | 9edd3f7341f8 |
children | 7e38c833fe2b |
files | src/share/vm/opto/block.cpp src/share/vm/opto/cfgnode.cpp src/share/vm/opto/compile.cpp src/share/vm/opto/domgraph.cpp src/share/vm/opto/gcm.cpp src/share/vm/opto/loopTransform.cpp src/share/vm/opto/loopnode.cpp src/share/vm/opto/matcher.cpp src/share/vm/opto/node.cpp src/share/vm/opto/phaseX.cpp |
diffstat | 10 files changed, 22 insertions(+), 18 deletions(-) [+] |
line wrap: on
line diff
--- a/src/share/vm/opto/block.cpp Thu Aug 06 13:00:44 2015 -0700 +++ b/src/share/vm/opto/block.cpp Mon Aug 10 10:39:19 2015 -0700 @@ -393,7 +393,7 @@ VectorSet visited(a); // Allocate stack with enough space to avoid frequent realloc - Node_Stack nstack(a, C->unique() >> 1); + Node_Stack nstack(a, C->live_nodes() >> 1); nstack.push(_root, 0); uint sum = 0; // Counter for blocks
--- a/src/share/vm/opto/cfgnode.cpp Thu Aug 06 13:00:44 2015 -0700 +++ b/src/share/vm/opto/cfgnode.cpp Mon Aug 10 10:39:19 2015 -0700 @@ -802,7 +802,7 @@ Compile *C = igvn->C; Arena *a = Thread::current()->resource_area(); Node_Array node_map = new Node_Array(a); - Node_Stack stack(a, C->unique() >> 4); + Node_Stack stack(a, C->live_nodes() >> 4); PhiNode *nphi = slice_memory(at); igvn->register_new_node_with_optimizer( nphi ); node_map.map(_idx, nphi);
--- a/src/share/vm/opto/compile.cpp Thu Aug 06 13:00:44 2015 -0700 +++ b/src/share/vm/opto/compile.cpp Mon Aug 10 10:39:19 2015 -0700 @@ -3315,7 +3315,7 @@ // Visit everybody reachable! // Allocate stack of size C->unique()/2 to avoid frequent realloc - Node_Stack nstack(unique() >> 1); + Node_Stack nstack(live_nodes() >> 1); final_graph_reshaping_walk(nstack, root(), frc); // Check for unreachable (from below) code (i.e., infinite loops).
--- a/src/share/vm/opto/domgraph.cpp Thu Aug 06 13:00:44 2015 -0700 +++ b/src/share/vm/opto/domgraph.cpp Mon Aug 10 10:39:19 2015 -0700 @@ -507,7 +507,7 @@ // 'semi' as vertex to DFS mapping. Set 'parent' to DFS parent. int NTarjan::DFS( NTarjan *ntarjan, VectorSet &visited, PhaseIdealLoop *pil, uint *dfsorder) { // Allocate stack of size C->unique()/8 to avoid frequent realloc - GrowableArray <Node *> dfstack(pil->C->unique() >> 3); + GrowableArray <Node *> dfstack(pil->C->live_nodes() >> 3); Node *b = pil->C->root(); int dfsnum = 1; dfsorder[b->_idx] = dfsnum; // Cache parent's dfsnum for a later use
--- a/src/share/vm/opto/gcm.cpp Thu Aug 06 13:00:44 2015 -0700 +++ b/src/share/vm/opto/gcm.cpp Mon Aug 10 10:39:19 2015 -0700 @@ -107,8 +107,8 @@ //------------------------------schedule_pinned_nodes-------------------------- // Set the basic block for Nodes pinned into blocks void PhaseCFG::schedule_pinned_nodes(VectorSet &visited) { - // Allocate node stack of size C->unique()+8 to avoid frequent realloc - GrowableArray <Node *> spstack(C->unique() + 8); + // Allocate node stack of size C->live_nodes()+8 to avoid frequent realloc + GrowableArray <Node *> spstack(C->live_nodes() + 8); spstack.push(_root); while (spstack.is_nonempty()) { Node* node = spstack.pop(); @@ -1310,7 +1310,7 @@ visited.Clear(); Node_List stack(arena); // Pre-grow the list - stack.map((C->unique() >> 1) + 16, NULL); + stack.map((C->live_nodes() >> 1) + 16, NULL); if (!schedule_early(visited, stack)) { // Bailout without retry C->record_method_not_compilable("early schedule failed");
--- a/src/share/vm/opto/loopTransform.cpp Thu Aug 06 13:00:44 2015 -0700 +++ b/src/share/vm/opto/loopTransform.cpp Mon Aug 10 10:39:19 2015 -0700 @@ -1282,7 +1282,7 @@ if (C->do_vector_loop() && (PrintOpto && VerifyLoopOptimizations || TraceLoopOpts)) { Arena* arena = Thread::current()->resource_area(); - Node_Stack stack(arena, C->unique() >> 2); + Node_Stack stack(arena, C->live_nodes() >> 2); Node_List rpo_list; VectorSet visited(arena); visited.set(loop_head->_idx);
--- a/src/share/vm/opto/loopnode.cpp Thu Aug 06 13:00:44 2015 -0700 +++ b/src/share/vm/opto/loopnode.cpp Mon Aug 10 10:39:19 2015 -0700 @@ -2231,7 +2231,7 @@ // _nodes array holds the earliest legal controlling CFG node. // Allocate stack with enough space to avoid frequent realloc - int stack_size = (C->unique() >> 1) + 16; // (unique>>1)+16 from Java2D stats + int stack_size = (C->live_nodes() >> 1) + 16; // (live_nodes>>1)+16 from Java2D stats Node_Stack nstack( a, stack_size ); visited.Clear(); @@ -2691,7 +2691,7 @@ } } if (_dom_stk == NULL) { - uint init_size = C->unique() / 100; // Guess that 1/100 is a reasonable initial size. + uint init_size = C->live_nodes() / 100; // Guess that 1/100 is a reasonable initial size. if (init_size < 10) init_size = 10; _dom_stk = new GrowableArray<uint>(init_size); } @@ -2781,8 +2781,8 @@ // The sort is of size number-of-control-children, which generally limits // it to size 2 (i.e., I just choose between my 2 target loops). void PhaseIdealLoop::build_loop_tree() { - // Allocate stack of size C->unique()/2 to avoid frequent realloc - GrowableArray <Node *> bltstack(C->unique() >> 1); + // Allocate stack of size C->live_nodes()/2 to avoid frequent realloc + GrowableArray <Node *> bltstack(C->live_nodes() >> 1); Node *n = C->root(); bltstack.push(n); int pre_order = 1; @@ -3672,7 +3672,7 @@ void PhaseIdealLoop::dump( ) const { ResourceMark rm; Arena* arena = Thread::current()->resource_area(); - Node_Stack stack(arena, C->unique() >> 2); + Node_Stack stack(arena, C->live_nodes() >> 2); Node_List rpo_list; VectorSet visited(arena); visited.set(C->top()->_idx);
--- a/src/share/vm/opto/matcher.cpp Thu Aug 06 13:00:44 2015 -0700 +++ b/src/share/vm/opto/matcher.cpp Mon Aug 10 10:39:19 2015 -0700 @@ -2050,7 +2050,7 @@ // Set bits if Node is shared or otherwise a root void Matcher::find_shared( Node *n ) { // Allocate stack of size C->unique() * 2 to avoid frequent realloc - MStack mstack(C->unique() * 2); + MStack mstack(C->live_nodes() * 2); // Mark nodes as address_visited if they are inputs to an address expression VectorSet address_visited(Thread::current()->resource_area()); mstack.push(n, Visit); // Don't need to pre-visit root node
--- a/src/share/vm/opto/node.cpp Thu Aug 06 13:00:44 2015 -0700 +++ b/src/share/vm/opto/node.cpp Mon Aug 10 10:39:19 2015 -0700 @@ -1799,7 +1799,7 @@ static void dump_nodes(const Node* start, int d, bool only_ctrl) { if (NotANode(start)) return; - GrowableArray <Node *> nstack(Compile::current()->unique()); + GrowableArray <Node *> nstack(Compile::current()->live_nodes()); collect_nodes_i(&nstack, start, d, (uint) ABS(d), true, only_ctrl, false); int end = nstack.length();
--- a/src/share/vm/opto/phaseX.cpp Thu Aug 06 13:00:44 2015 -0700 +++ b/src/share/vm/opto/phaseX.cpp Mon Aug 10 10:39:19 2015 -0700 @@ -791,7 +791,7 @@ //------------------------------PhaseIterGVN----------------------------------- // Initialize hash table to fresh and clean for +VerifyOpto PhaseIterGVN::PhaseIterGVN( PhaseIterGVN *igvn, const char *dummy ) : PhaseGVN(igvn,dummy), _worklist( ), - _stack(C->unique() >> 1), + _stack(C->live_nodes() >> 1), _delay_transform(false) { } @@ -808,7 +808,11 @@ // Initialize with previous PhaseGVN info from Parser PhaseIterGVN::PhaseIterGVN( PhaseGVN *gvn ) : PhaseGVN(gvn), _worklist(*C->for_igvn()), - _stack(C->unique() >> 1), +// TODO: Before incremental inlining it was allocated only once and it was fine. Now that +// the constructor is used in incremental inlining, this consumes too much memory: +// _stack(C->live_nodes() >> 1), +// So, as a band-aid, we replace this by: + _stack(C->comp_arena(), 32), _delay_transform(false) { uint max; @@ -1638,7 +1642,7 @@ _nodes.map( n->_idx, new_node ); // Flag as having been cloned // Allocate stack of size _nodes.Size()/2 to avoid frequent realloc - GrowableArray <Node *> trstack(C->unique() >> 1); + GrowableArray <Node *> trstack(C->live_nodes() >> 1); trstack.push(new_node); // Process children of cloned node while ( trstack.is_nonempty() ) {