changeset 54143:7e17825e47e7

8253167: ARM32 builds fail after JDK-8247910 8213483: ARM32: runtime/ErrorHandling/ShowRegistersOnAssertTest.java jtreg test fail Summary: Removed platform-dependent definitions of BREAKPOINT as asm(breakpoint instruction). Reviewed-by: coleenp, mikael, bulasevich
author kbarrett
date Mon, 21 Sep 2020 00:31:26 +0000
parents c21583450aa8
children 9077f274b303
files src/hotspot/cpu/arm/globalDefinitions_arm.hpp src/hotspot/share/utilities/breakpoint.hpp
diffstat 2 files changed, 1 insertions(+), 19 deletions(-) [+]
line wrap: on
line diff
--- a/src/hotspot/cpu/arm/globalDefinitions_arm.hpp	Thu Apr 01 10:43:45 2021 +0000
+++ b/src/hotspot/cpu/arm/globalDefinitions_arm.hpp	Mon Sep 21 00:31:26 2020 +0000
@@ -69,11 +69,4 @@
 #endif
 #define C1_LIRGENERATOR_MD_HPP "c1_LIRGenerator_arm.hpp"
 
-#ifdef TARGET_COMPILER_gcc
-#ifdef ARM32
-#undef BREAKPOINT
-#define BREAKPOINT __asm__ volatile ("bkpt")
-#endif
-#endif
-
 #endif // CPU_ARM_VM_GLOBALDEFINITIONS_ARM_HPP
--- a/src/hotspot/share/utilities/breakpoint.hpp	Thu Apr 01 10:43:45 2021 +0000
+++ b/src/hotspot/share/utilities/breakpoint.hpp	Mon Sep 21 00:31:26 2020 +0000
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2017, 2020, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -25,17 +25,6 @@
 #ifndef SHARE_VM_UTILITIES_BREAKPOINT_HPP
 #define SHARE_VM_UTILITIES_BREAKPOINT_HPP
 
-// Provide BREAKPOINT macro for requesting stop in the debugger.
-
-// We presently only have one non-default definition, so it's not
-// worth going through the COMPILER_HEADER() dispatch, with all
-// non-visCPP files being empty.
-#ifdef TARGET_COMPILER_visCPP
-#ifndef _WIN64
-#define BREAKPOINT __asm { int 3 }
-#endif // _WIN64
-#endif //  TARGET_COMPILER_visCPP
-
 // If no more specific definition provided, default to calling a
 // function that is defined per-platform.  See also os::breakpoint().
 #ifndef BREAKPOINT