changeset 58302:2420daa87866

8240133: G1DirtyCardQueue destructor has useless flush Summary: Removed useless call to flush. Reviewed-by: tschatzl, sjohanss
author kbarrett
date Sun, 08 Mar 2020 17:33:48 -0400
parents e44b68e5bdaf
children 0fe71e38ecc4
files src/hotspot/share/gc/g1/g1DirtyCardQueue.cpp src/hotspot/share/gc/g1/g1DirtyCardQueue.hpp
diffstat 2 files changed, 0 insertions(+), 8 deletions(-) [+]
line wrap: on
line diff
--- a/src/hotspot/share/gc/g1/g1DirtyCardQueue.cpp	Sun Mar 08 15:15:38 2020 +0900
+++ b/src/hotspot/share/gc/g1/g1DirtyCardQueue.cpp	Sun Mar 08 17:33:48 2020 -0400
@@ -50,10 +50,6 @@
   PtrQueue(qset, true /* active */)
 { }
 
-G1DirtyCardQueue::~G1DirtyCardQueue() {
-  flush();
-}
-
 void G1DirtyCardQueue::handle_completed_buffer() {
   assert(_buf != NULL, "precondition");
   BufferNode* node = BufferNode::make_node_from_buffer(_buf, index());
--- a/src/hotspot/share/gc/g1/g1DirtyCardQueue.hpp	Sun Mar 08 15:15:38 2020 +0900
+++ b/src/hotspot/share/gc/g1/g1DirtyCardQueue.hpp	Sun Mar 08 17:33:48 2020 -0400
@@ -44,10 +44,6 @@
 public:
   G1DirtyCardQueue(G1DirtyCardQueueSet* qset);
 
-  // Flush before destroying; queue may be used to capture pending work while
-  // doing something else, with auto-flush on completion.
-  ~G1DirtyCardQueue();
-
   // Process queue entries and release resources.
   void flush() { flush_impl(); }