changeset 57064:46084917fde7

8164993: (ch) ReadableByteChannel should note a possible IllegalArgumentException Reviewed-by: alanb, darcy
author bpb
date Fri, 22 Nov 2019 09:00:16 -0800
parents a0f39cc47387
children ddb327877207
files src/java.base/share/classes/java/nio/channels/DatagramChannel.java src/java.base/share/classes/java/nio/channels/FileChannel.java src/java.base/share/classes/java/nio/channels/ReadableByteChannel.java src/java.base/share/classes/java/nio/channels/ScatteringByteChannel.java
diffstat 4 files changed, 16 insertions(+), 4 deletions(-) [+]
line wrap: on
line diff
--- a/src/java.base/share/classes/java/nio/channels/DatagramChannel.java	Fri Nov 22 17:20:43 2019 +0100
+++ b/src/java.base/share/classes/java/nio/channels/DatagramChannel.java	Fri Nov 22 09:00:16 2019 -0800
@@ -403,6 +403,9 @@
      *          or {@code null} if this channel is in non-blocking mode
      *          and no datagram was immediately available
      *
+     * @throws  IllegalArgumentException
+     *          If the buffer is read-only
+     *
      * @throws  ClosedChannelException
      *          If this channel is closed
      *
--- a/src/java.base/share/classes/java/nio/channels/FileChannel.java	Fri Nov 22 17:20:43 2019 +0100
+++ b/src/java.base/share/classes/java/nio/channels/FileChannel.java	Fri Nov 22 09:00:16 2019 -0800
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2000, 2018, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2000, 2019, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -719,7 +719,7 @@
      *          size
      *
      * @throws  IllegalArgumentException
-     *          If the position is negative
+     *          If the position is negative or the buffer is read-only
      *
      * @throws  NonReadableChannelException
      *          If this channel was not opened for reading
--- a/src/java.base/share/classes/java/nio/channels/ReadableByteChannel.java	Fri Nov 22 17:20:43 2019 +0100
+++ b/src/java.base/share/classes/java/nio/channels/ReadableByteChannel.java	Fri Nov 22 09:00:16 2019 -0800
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2000, 2001, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2000, 2019, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -84,6 +84,9 @@
      * @return  The number of bytes read, possibly zero, or {@code -1} if the
      *          channel has reached end-of-stream
      *
+     * @throws  IllegalArgumentException
+     *          If the buffer is read-only
+     *
      * @throws  NonReadableChannelException
      *          If this channel was not opened for reading
      *
--- a/src/java.base/share/classes/java/nio/channels/ScatteringByteChannel.java	Fri Nov 22 17:20:43 2019 +0100
+++ b/src/java.base/share/classes/java/nio/channels/ScatteringByteChannel.java	Fri Nov 22 09:00:16 2019 -0800
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2000, 2006, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2000, 2019, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -101,6 +101,9 @@
      *          If the preconditions on the {@code offset} and {@code length}
      *          parameters do not hold
      *
+     * @throws  IllegalArgumentException
+     *          If any of the buffers is read-only
+     *
      * @throws  NonReadableChannelException
      *          If this channel was not opened for reading
      *
@@ -138,6 +141,9 @@
      * @return The number of bytes read, possibly zero,
      *         or {@code -1} if the channel has reached end-of-stream
      *
+     * @throws  IllegalArgumentException
+     *          If any of the buffers is read-only
+     *
      * @throws  NonReadableChannelException
      *          If this channel was not opened for reading
      *