changeset 57033:b9bde9d224b9

8190763: Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit() Reviewed-by: psadhukhan, pbansal, serb
author trebari
date Wed, 20 Nov 2019 12:18:46 +0530
parents 10385df5d986
children 7567ce83f3b5
files src/java.desktop/share/classes/javax/swing/text/AbstractDocument.java test/jdk/javax/swing/text/AbstractDocument/8190763/TestCCEOnEditEvent.java
diffstat 2 files changed, 134 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/src/java.desktop/share/classes/javax/swing/text/AbstractDocument.java	Wed Nov 20 11:29:27 2019 +0530
+++ b/src/java.desktop/share/classes/javax/swing/text/AbstractDocument.java	Wed Nov 20 12:18:46 2019 +0530
@@ -2961,11 +2961,12 @@
 
     }
 
-    static class DefaultDocumentEventUndoableWrapper implements
+    class DefaultDocumentEventUndoableWrapper extends DefaultDocumentEvent implements
             UndoableEdit, UndoableEditLockSupport
     {
         final DefaultDocumentEvent dde;
         public DefaultDocumentEventUndoableWrapper(DefaultDocumentEvent dde) {
+            super(dde.getOffset(),dde.getLength(),dde.type);
             this.dde = dde;
         }
 
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/test/jdk/javax/swing/text/AbstractDocument/8190763/TestCCEOnEditEvent.java	Wed Nov 20 12:18:46 2019 +0530
@@ -0,0 +1,132 @@
+/*
+ * Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+import java.awt.Container;
+import java.awt.event.KeyEvent;
+import java.awt.Robot;
+import javax.swing.JFrame;
+import javax.swing.JScrollPane;
+import javax.swing.JTextArea;
+import javax.swing.SwingUtilities;
+import javax.swing.event.DocumentEvent;
+import javax.swing.event.UndoableEditEvent;
+import javax.swing.event.UndoableEditListener;
+import javax.swing.text.BadLocationException;
+import javax.swing.text.AbstractDocument;
+import javax.swing.text.Document;
+import javax.swing.text.PlainDocument;
+import javax.swing.undo.CompoundEdit;
+import javax.swing.undo.UndoManager;
+
+/*
+ * @test
+ * @key headful
+ * @bug 8190763
+ * @summary Class Cast Exception on (CompoundEdit) UndoableEditEvent.getEdit()
+ * @run main TestCCEOnEditEvent
+ */
+public class TestCCEOnEditEvent {
+    private Container contentPane = null;
+    private JTextArea textArea = null;
+    private static Robot robot;
+    private static JFrame frame;
+    public static void main(String[] arguments) throws Exception {
+        try{
+            robot = new Robot();
+            robot.setAutoDelay(50);
+            TestCCEOnEditEvent test = new TestCCEOnEditEvent();
+            SwingUtilities.invokeAndWait(new Runnable() {
+                @Override
+                public void run() {
+                    test.createAndShowGUI();
+                }
+            });
+
+            robot.keyPress(KeyEvent.VK_ENTER);
+            robot.keyRelease(KeyEvent.VK_ENTER);
+            robot.waitForIdle();
+        } finally {
+            SwingUtilities.invokeLater(new Runnable(){
+                @Override
+                public void run(){
+                    frame.dispose();
+                }
+            });
+        }
+    }
+
+    public void createAndShowGUI() {
+        frame = new JFrame();
+        contentPane  = frame.getContentPane();
+        createTextArea();
+        frame.setSize(200, 200);
+        frame.setVisible(true);
+    }
+
+    private void createTextArea() {
+        textArea = new JTextArea("Text Area") {
+            @Override
+            protected Document createDefaultModel() {
+                return new PlainDocument() {
+                    @Override
+                    protected void fireUndoableEditUpdate(UndoableEditEvent event) {
+                        Object[] listeners = listenerList.getListenerList();
+                        for (int index = listeners.length - 2; index >= 0; index -= 2) {
+                            Object listenerType = listeners[index];
+                            if (listenerType == UndoableEditListener.class) {
+                                super.fireUndoableEditUpdate(event);
+                            }
+                        }
+                    }
+                };
+            }
+        };
+        textArea.getDocument().addUndoableEditListener(new UndoManager() {
+            @Override
+            public void undoableEditHappened(UndoableEditEvent event) {
+                CompoundEdit edit = null;
+                try {
+                    edit = (CompoundEdit) event.getEdit();
+                }
+                catch(ClassCastException e ) {
+                    throw new RuntimeException("Class Cast Exception is thrown on (CompoundEdit) UndoableEditEvent.getEdit()");
+                }
+                AbstractDocument.DefaultDocumentEvent documentEvent =
+                        (AbstractDocument.DefaultDocumentEvent) edit;
+                DocumentEvent.EventType editType = documentEvent.getType();
+                int editOffset = documentEvent.getOffset();
+                int editLength = documentEvent.getLength();
+
+            }
+        });
+        try {
+            textArea.setSelectionStart(textArea.getLineEndOffset(0));
+        }
+        catch (BadLocationException exception) {
+        }
+        JScrollPane scrollPane = new JScrollPane(textArea,
+                        JScrollPane.VERTICAL_SCROLLBAR_ALWAYS,
+                        JScrollPane.HORIZONTAL_SCROLLBAR_ALWAYS);
+
+        contentPane.add(scrollPane);
+    }
+}