changeset 56982:bd436284147d

8234377: new BitArray(0).toString() throws ArrayIndexOutOfBoundsException Reviewed-by: mullan, wetmore
author weijun
date Wed, 20 Nov 2019 08:12:14 +0800
parents f68fd04fe463
children c4be5e03aff7
files src/java.base/share/classes/sun/security/util/BitArray.java test/jdk/sun/security/util/BitArray/EmptyBitArray.java
diffstat 2 files changed, 42 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/src/java.base/share/classes/sun/security/util/BitArray.java	Tue Nov 19 23:22:27 2019 +0100
+++ b/src/java.base/share/classes/sun/security/util/BitArray.java	Wed Nov 20 08:12:14 2019 +0800
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1997, 2006, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1997, 2019, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -241,6 +241,10 @@
      *  Returns a string representation of this BitArray.
      */
     public String toString() {
+        if (length == 0) {
+            return "";
+        }
+
         ByteArrayOutputStream out = new ByteArrayOutputStream();
 
         for (int i = 0; i < repn.length - 1; i++) {
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/test/jdk/sun/security/util/BitArray/EmptyBitArray.java	Wed Nov 20 08:12:14 2019 +0800
@@ -0,0 +1,37 @@
+/*
+ * Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/*
+ * @test
+ * @bug 8234377
+ * @summary new BitArray(0).toString() throws ArrayIndexOutOfBoundsException
+ * @modules java.base/sun.security.util
+ */
+
+import sun.security.util.BitArray;
+
+public class EmptyBitArray {
+    public static void main(String[] args) {
+        new BitArray(0).toString();
+    }
+}