OpenJDK / jdk / jdk
changeset 34237:c34adffc35c0
8143255: Remove debug logging from SymbolTable::unlink() and SymbolTable::possibly_parallel_unlink()
Reviewed-by: coleenp, tschatzl
| author | brutisso |
|---|---|
| date | Thu, 19 Nov 2015 16:14:45 +0100 |
| parents | e4a23d294f48 |
| children | 5a67344e5ef3 |
| files | hotspot/src/share/vm/classfile/symbolTable.cpp hotspot/src/share/vm/classfile/symbolTable.hpp |
| diffstat | 2 files changed, 4 insertions(+), 17 deletions(-) [+] |
line wrap: on
line diff
--- a/hotspot/src/share/vm/classfile/symbolTable.cpp Wed Nov 18 22:00:09 2015 +0000 +++ b/hotspot/src/share/vm/classfile/symbolTable.cpp Thu Nov 19 16:14:45 2015 +0100 @@ -97,7 +97,7 @@ int SymbolTable::_symbols_counted = 0; volatile int SymbolTable::_parallel_claimed_idx = 0; -void SymbolTable::buckets_unlink(int start_idx, int end_idx, int* processed, int* removed, size_t* memory_total) { +void SymbolTable::buckets_unlink(int start_idx, int end_idx, int* processed, int* removed) { for (int i = start_idx; i < end_idx; ++i) { HashtableEntry<Symbol*, mtSymbol>** p = the_table()->bucket_addr(i); HashtableEntry<Symbol*, mtSymbol>* entry = the_table()->bucket(i); @@ -110,7 +110,6 @@ break; } Symbol* s = entry->literal(); - (*memory_total) += s->size(); (*processed)++; assert(s != NULL, "just checking"); // If reference count is zero, remove. @@ -133,15 +132,9 @@ // This is done late during GC. void SymbolTable::unlink(int* processed, int* removed) { size_t memory_total = 0; - buckets_unlink(0, the_table()->table_size(), processed, removed, &memory_total); + buckets_unlink(0, the_table()->table_size(), processed, removed); _symbols_removed += *removed; _symbols_counted += *processed; - // Exclude printing for normal PrintGCDetails because people parse - // this output. - if (PrintGCDetails && Verbose && WizardMode) { - gclog_or_tty->print(" [Symbols=%d size=" SIZE_FORMAT "K] ", *processed, - (memory_total*HeapWordSize)/1024); - } } void SymbolTable::possibly_parallel_unlink(int* processed, int* removed) { @@ -158,16 +151,10 @@ } int end_idx = MIN2(limit, start_idx + ClaimChunkSize); - buckets_unlink(start_idx, end_idx, processed, removed, &memory_total); + buckets_unlink(start_idx, end_idx, processed, removed); } Atomic::add(*processed, &_symbols_counted); Atomic::add(*removed, &_symbols_removed); - // Exclude printing for normal PrintGCDetails because people parse - // this output. - if (PrintGCDetails && Verbose && WizardMode) { - gclog_or_tty->print(" [Symbols: scanned=%d removed=%d size=" SIZE_FORMAT "K] ", *processed, *removed, - (memory_total*HeapWordSize)/1024); - } } // Create a new table and using alternate hash code, populate the new table
--- a/hotspot/src/share/vm/classfile/symbolTable.hpp Wed Nov 18 22:00:09 2015 +0000 +++ b/hotspot/src/share/vm/classfile/symbolTable.hpp Thu Nov 19 16:14:45 2015 +0100 @@ -132,7 +132,7 @@ static volatile int _parallel_claimed_idx; // Release any dead symbols - static void buckets_unlink(int start_idx, int end_idx, int* processed, int* removed, size_t* memory_total); + static void buckets_unlink(int start_idx, int end_idx, int* processed, int* removed); public: enum { symbol_alloc_batch_size = 8,