changeset 57495:eccb8316306d

8236582: (fc) FileChannel.map fails with InternalError when security manager enabled Reviewed-by: alanb
author bpb
date Thu, 09 Jan 2020 08:31:29 -0800
parents f393f34a48cd
children 5de55aa0cfdb
files src/java.base/share/classes/jdk/internal/misc/ExtendedMapMode.java test/jdk/java/nio/channels/FileChannel/MapWithSecurityManager.java
diffstat 2 files changed, 48 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/src/java.base/share/classes/jdk/internal/misc/ExtendedMapMode.java	Thu Jan 09 16:14:14 2020 +0100
+++ b/src/java.base/share/classes/jdk/internal/misc/ExtendedMapMode.java	Thu Jan 09 08:31:29 2020 -0800
@@ -27,8 +27,11 @@
 
 import java.lang.invoke.MethodHandle;
 import java.lang.invoke.MethodHandles;
+import java.lang.invoke.MethodHandles.Lookup;
 import java.lang.invoke.MethodType;
 import java.nio.channels.FileChannel.MapMode;
+import java.security.AccessController;
+import java.security.PrivilegedExceptionAction;
 
 /**
  * JDK-specific map modes implemented in java.base.
@@ -36,10 +39,11 @@
 public class ExtendedMapMode {
 
     static final MethodHandle MAP_MODE_CONSTRUCTOR;
-
     static {
         try {
-            var lookup = MethodHandles.privateLookupIn(MapMode.class, MethodHandles.lookup());
+            PrivilegedExceptionAction<Lookup> pae = () ->
+                MethodHandles.privateLookupIn(MapMode.class, MethodHandles.lookup());
+            Lookup lookup = AccessController.doPrivileged(pae);
             var methodType = MethodType.methodType(void.class, String.class);
             MAP_MODE_CONSTRUCTOR = lookup.findConstructor(MapMode.class, methodType);
         } catch (Exception e) {
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/test/jdk/java/nio/channels/FileChannel/MapWithSecurityManager.java	Thu Jan 09 08:31:29 2020 -0800
@@ -0,0 +1,42 @@
+/*
+ * Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/* @test
+ * @bug 8236582
+ * @summary Tests the map method when running with a security manager
+ */
+
+import java.io.IOException;
+import java.nio.channels.FileChannel;
+import java.nio.file.Files;
+import java.nio.file.Path;
+
+public class MapWithSecurityManager {
+    public static void main(String[] args) throws IOException {
+        Path tempFile = Files.createTempFile("test", "test");
+        try (FileChannel ch = FileChannel.open(tempFile)) {
+             System.setSecurityManager(new SecurityManager());
+             ch.map(FileChannel.MapMode.READ_ONLY, 0, 0);
+        }
+    }
+}