OpenJDK / portola / portola
changeset 39964:7e00eb091e5a
8159901: missing newline char in the exception messages in diagnosticArgument.cpp
Reviewed-by: fparain, egahlin, iklam
author | ccheung |
---|---|
date | Wed, 13 Jul 2016 18:26:51 -0700 |
parents | 5921b7f27d63 |
children | 5955109add86 |
files | hotspot/src/share/vm/services/diagnosticArgument.cpp |
diffstat | 1 files changed, 10 insertions(+), 11 deletions(-) [+] |
line wrap: on
line diff
--- a/hotspot/src/share/vm/services/diagnosticArgument.cpp Thu Jul 07 18:40:53 2016 +0100 +++ b/hotspot/src/share/vm/services/diagnosticArgument.cpp Wed Jul 13 18:26:51 2016 -0700 @@ -98,7 +98,7 @@ strncpy(buf, str, len); buf[len] = '\0'; Exceptions::fthrow(THREAD_AND_LOCATION, vmSymbols::java_lang_IllegalArgumentException(), - "Integer parsing error in command argument '%s'. Could not parse: %s.", _name, buf); + "Integer parsing error in command argument '%s'. Could not parse: %s.\n", _name, buf); } } @@ -132,7 +132,7 @@ strncpy(buf, str, len); buf[len] = '\0'; Exceptions::fthrow(THREAD_AND_LOCATION, vmSymbols::java_lang_IllegalArgumentException(), - "Boolean parsing error in command argument '%s'. Could not parse: %s.", _name, buf); + "Boolean parsing error in command argument '%s'. Could not parse: %s.\n", _name, buf); } } } @@ -183,13 +183,13 @@ size_t len, TRAPS) { if (str == NULL) { THROW_MSG(vmSymbols::java_lang_IllegalArgumentException(), - "Integer parsing error nanotime value: syntax error, value is null"); + "Integer parsing error nanotime value: syntax error, value is null\n"); } int argc = sscanf(str, JLONG_FORMAT, &_value._time); if (argc != 1) { THROW_MSG(vmSymbols::java_lang_IllegalArgumentException(), - "Integer parsing error nanotime value: syntax error"); + "Integer parsing error nanotime value: syntax error\n"); } size_t idx = 0; while(idx < len && isdigit(str[idx])) { @@ -199,7 +199,7 @@ // only accept missing unit if the value is 0 if (_value._time != 0) { THROW_MSG(vmSymbols::java_lang_IllegalArgumentException(), - "Integer parsing error nanotime value: unit required"); + "Integer parsing error nanotime value: unit required\n"); } else { _value._nanotime = 0; strcpy(_value._unit, "ns"); @@ -207,7 +207,7 @@ } } else if(len - idx > 2) { THROW_MSG(vmSymbols::java_lang_IllegalArgumentException(), - "Integer parsing error nanotime value: illegal unit"); + "Integer parsing error nanotime value: illegal unit\n"); } else { strncpy(_value._unit, &str[idx], len - idx); /*Write an extra null termination. This is safe because _value._unit @@ -234,7 +234,7 @@ _value._nanotime = _value._time * 24 * 60 * 60 * 1000 * 1000 * 1000; } else { THROW_MSG(vmSymbols::java_lang_IllegalArgumentException(), - "Integer parsing error nanotime value: illegal unit"); + "Integer parsing error nanotime value: illegal unit\n"); } } @@ -280,12 +280,11 @@ size_t len, TRAPS) { if (str == NULL) { THROW_MSG(vmSymbols::java_lang_IllegalArgumentException(), - "Parsing error memory size value: syntax error, value is null"); + "Parsing error memory size value: syntax error, value is null\n"); } - if (*str == '-') { THROW_MSG(vmSymbols::java_lang_IllegalArgumentException(), - "Parsing error memory size value: negative values not allowed"); + "Parsing error memory size value: negative values not allowed\n"); } int res = sscanf(str, UINT64_FORMAT "%c", &_value._val, &_value._multiplier); if (res == 2) { @@ -310,7 +309,7 @@ _value._size = _value._val; } else { THROW_MSG(vmSymbols::java_lang_IllegalArgumentException(), - "Parsing error memory size value: invalid value"); + "Parsing error memory size value: invalid value\n"); } }